This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] Allow BFD to recognize macOS universal libraries
- From: Alan Modra <amodra at gmail dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: binutils at sourceware dot org
- Date: Sat, 30 Jun 2018 17:08:00 +0930
- Subject: Re: [RFA] Allow BFD to recognize macOS universal libraries
- References: <20180628150338.5282-1-tom@tromey.com>
On Thu, Jun 28, 2018 at 09:03:38AM -0600, Tom Tromey wrote:
> bfd/ChangeLog
> 2018-06-28 Jeff Muizelaar <jrmuizel@gmail.com>
> Tom Tromey <tom@tromey.com>
>
> PR symtab/13157:
> * mach-o.c (bfd_mach_o_fat_close_and_cleanup): New function.
> (bfd_mach_o_close_and_cleanup): Redefine.
> * libbfd.h: Rebuild.
> * libbfd-in.h (_bfd_unlink_from_archive_parent): Declare.
> * archive.c (_bfd_unlink_from_archive_parent): New function.
> (_bfd_archive_close_and_cleanup): Call it.
> (bfd_generic_archive_p): Do not set archive's format.
Looks OK to me. I think the changelog should mention pr21787 too, and
since I'm being picky about that it's worth mentioning that a "new"
function isn't really new but extracted from existing code. Thus:
PR 13157
PR 21787
* mach-o.c (bfd_mach_o_fat_close_and_cleanup): New function.
(bfd_mach_o_close_and_cleanup): Redefine.
* archive.c (_bfd_unlink_from_archive_parent): New function,
extracted from..
(_bfd_archive_close_and_cleanup): ..here.
(bfd_generic_archive_p): Do not clear archive's format.
* libbfd-in.h (_bfd_unlink_from_archive_parent): Declare.
* libbfd.h: Regenerate.
--
Alan Modra
Australia Development Lab, IBM