This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [0/4] C-SKY port
- From: Alan Modra <amodra at gmail dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: binutils at sourceware dot org, "nickc at redhat dot com" <nickc at redhat dot com>, Lifang Xia <lifang_xia at c-sky dot com>, Yunhai Shang <yunhai_shang at c-sky dot com>
- Date: Thu, 24 May 2018 13:23:34 +0930
- Subject: Re: [0/4] C-SKY port
- References: <015d7738-5a15-d9b8-7c3d-cc21a3d412de@codesourcery.com>
On Wed, May 23, 2018 at 05:49:55PM -0600, Sandra Loosemore wrote:
> This patch series is a new binutils port for C-SKY processors, including
Here's an immediate cursory review, courtesy of git. You can
reproduce it by adding the following to your .git/config under [core]
whitespace = indent-with-non-tab,space-before-tab,trailing-space
git diff should then highlight the errors for you.
$ git am /tmp/csky
Applying: PATCH [1/4] C-SKY port: ELF and BFD support
.git/rebase-apply/patch:141: trailing whitespace.
extern void elf32_csky_next_input_section
.git/rebase-apply/patch:161: trailing whitespace.
extern void elf32_csky_next_input_section
.git/rebase-apply/patch:1671: trailing whitespace.
.git/rebase-apply/patch:1677: trailing whitespace.
.git/rebase-apply/patch:2928: trailing whitespace.
warning: squelched 76 whitespace errors
warning: 81 lines add whitespace errors.
Applying: PATCH [2/4] C-SKY port: opcodes library
.git/rebase-apply/patch:532: trailing whitespace.
.git/rebase-apply/patch:569: trailing whitespace.
.git/rebase-apply/patch:571: trailing whitespace.
.git/rebase-apply/patch:630: trailing whitespace.
.git/rebase-apply/patch:633: trailing whitespace.
warning: squelched 65 whitespace errors
warning: 70 lines add whitespace errors.
Applying: PATCH [3/4] C-SKY port: assembler
.git/rebase-apply/patch:944: trailing whitespace.
.git/rebase-apply/patch:1711: trailing whitespace.
.git/rebase-apply/patch:1997: trailing whitespace.
.git/rebase-apply/patch:2002: trailing whitespace.
.git/rebase-apply/patch:2022: trailing whitespace.
warning: squelched 73 whitespace errors
warning: 78 lines add whitespace errors.
Applying: PATCH [4/4] C-SKY port: linker
.git/rebase-apply/patch:408: trailing whitespace.
int ret = elf32_csky_setup_section_lists (link_info.output_bfd,
.git/rebase-apply/patch:579: trailing whitespace.
sections to appear either before or after the branches. Values of
.git/rebase-apply/patch:598: trailing whitespace.
return
.git/rebase-apply/patch:1309: indent with spaces.
.*
.git/rebase-apply/patch:1311: indent with spaces.
.*
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
--
Alan Modra
Australia Development Lab, IBM