This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN

On Sun, May 20, 2018 at 09:02:24PM -0700, H.J. Lu wrote:
> On Sun, May 20, 2018 at 7:11 PM, Alan Modra <amodra@gmail.com> wrote:
> > FAIL: ld-i386/pr23194
> >
> > and a similar result for ld-x86-64/pr23194
> 
> I can't reproduce it on native x86-64 nor i686.

Hmm, the failures disappeared when testing with your latest patch.  I
suppose it might have been fixed by one of the other x86 patches that
have gone in recently.

> Here is the updated patch which avoids making forced local symbol
> dynamic.  There are no regressions on native x86-64 and i686 as
> well as for cross ppc-linux and ppc64-linux.

OK.  It still feels like a hack to me, but trying to run
record_link_assignment earlier will probably have its own set of
problems.

-- 
Alan Modra
Australia Development Lab, IBM
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]