This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/7] bfd:pru: Fix LDI32 relocation to conform to TI ABI
- From: Dimitar Dimitrov <dimitar at dinux dot eu>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 01 May 2018 22:47:34 +0300
- Subject: Re: [PATCH 1/7] bfd:pru: Fix LDI32 relocation to conform to TI ABI
- References: <20180428192827.18401-1-dimitar@dinux.eu> <2e7fe474-8b33-fe4b-968e-7d3cb192be42@redhat.com>
On вторник, 1 май 2018 г. 16:47:17 EEST Nick Clifton wrote:
> Hi Dimitar,
>
> > This patch will break binary compatibility with previously released
> > binutils versions for PRU. Still, I think it is better to fix
> > binutils to conform to the chip vendor ABI.
>
> This does worry me though. Will the patched code be able to detect
> old binaries, compiled/assembled with the wrong ABI support, and issue
> an error message of some kind ?
>
> Cheers
> Nick
The current patch detects old object files using this line:
+ BFD_ASSERT (GET_INSN_FIELD (RDSEL, insn) == RSEL_15_0);
I will add a human error message and will resend the patch set.
Thanks,Dimitar