This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH 2/5] x86: tighten assertion in build_modrm_byte()
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: <binutils at sourceware dot org>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Wed, 25 Apr 2018 02:29:15 -0600
- Subject: [PATCH 2/5] x86: tighten assertion in build_modrm_byte()
- References: <5AE03B3D02000078001BE439@prv1-mh.provo.novell.com>
>>> On 25.04.18 at 10:24, <JBeulich@suse.com> wrote:
All VEX3SOURCES cases should have VexW set, and all should have a SIMD
register destination.
gas/
2018-04-25 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (build_modrm_byte): Extend assertion in
vex_3_sources handling to cover more cases.
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -6591,10 +6591,9 @@ build_modrm_byte (void)
&& i.tm.opcode_modifier.vexvvvv == VEXXDS
&& (i.tm.opcode_modifier.veximmext
|| (i.imm_operands == 1
- && i.types[0].bitfield.vec_imm4
- && (i.tm.opcode_modifier.vexw == VEXW0
- || i.tm.opcode_modifier.vexw == VEXW1)
- && i.tm.operand_types[dest].bitfield.regsimd)));
+ && i.types[0].bitfield.vec_imm4))
+ && i.tm.opcode_modifier.vexw
+ && i.tm.operand_types[dest].bitfield.regsimd);
if (i.imm_operands == 0)
{