[PATCH 1/2] testsuite: Support filtering targets by TCL procedure in `run_dump_test'

["Maciej W. Rozycki" <macro at mips dot com>]

Implement a more complex way of selecting targets to include or exclude 
with `run_dump_test' cases, by extending the syntax for the `target', 
`not-target', `skip' and `not-skip' options (with the binutils and GAS 
test suites) and the `target', `alltargets' and `notarget' options (with 
the LD test suite) to also accept a name of a TCL procedure instead of a 
target triplet glob matching expression.  The result, 1 or 0, of the 
procedure determines whether the test is to be run or not.  This mimics 
and expands `dg-require-effective-target' from the GCC test suite.

Names of TCL procedures are supplied in square brackets `[]' as with TCL 
procedure calls, observing that target triplet glob matching expressions 
do not normally start and end with matching square brackets both at a 
time.  Arguments for procedures are allowed if required.

Having a way to specify a complex condition for a `run_dump_test' case 
to run has the advantage of keeping it local within the test case itself 
where tool options related to the check might be also present, removing 
the need to wrap `run_dump_test' calls into an `if' block whose only 
reason is to do a feature check, and ultimately lets one have the test 
reported as UNSUPPORTED automagically if required (not currently 
supported by the `run_dump_test' options used for LD).

	binutils/
	* testsuite/lib/binutils-common.exp (match_target): New procedure.
	* testsuite/lib/utils-lib.exp (run_dump_test): Use it in place
	of `istarget' for matching with `target', `not-target', `skip' 
	and `not-skip' options.

	gas/
	* testsuite/lib/gas-defs.exp (run_dump_test): Use `match_target' 
	in place of `istarget' for matching with `target', `not-target', 
	`skip' and `not-skip' options.

	ld/
	* testsuite/lib/ld-lib.exp (run_dump_test): Use `match_target' 
	in place of `istarget' for matching with `target', `alltargets' 
	and `notarget' options.
---
Hi,

 No regressions against the usual targets.  OK to apply?

  Maciej
---
 binutils/testsuite/lib/binutils-common.exp |   11 ++++++++
 binutils/testsuite/lib/utils-lib.exp       |   36 ++++++++++++++++-------------
 gas/testsuite/lib/gas-defs.exp             |   36 ++++++++++++++++-------------
 ld/testsuite/lib/ld-lib.exp                |   31 +++++++++++++++---------
 4 files changed, 70 insertions(+), 44 deletions(-)

binutils-test-effective-target.diff
Index: binutils/binutils/testsuite/lib/binutils-common.exp
===================================================================
--- binutils.orig/binutils/testsuite/lib/binutils-common.exp	2018-04-11 17:30:16.360205717 +0100
+++ binutils/binutils/testsuite/lib/binutils-common.exp	2018-04-11 17:41:35.850353490 +0100
@@ -163,6 +163,17 @@ proc is_elf64 { binary_file } {
     return 0
 }
 
+# True if the target matches TARGET, specified as a TCL procedure if
+# in square brackets or as machine triplet otherwise.
+#
+proc match_target { target } {
+   if [string match {\[*\]} $target] {
+	return $target
+   } else {
+	return [istarget $target]
+   }
+}
+
 # True if the ELF target supports STB_GNU_UNIQUE with the ELF header's
 # OSABI field set to ELFOSABI_GNU.
 #
Index: binutils/binutils/testsuite/lib/utils-lib.exp
===================================================================
--- binutils.orig/binutils/testsuite/lib/utils-lib.exp	2018-04-11 17:30:16.381405244 +0100
+++ binutils/binutils/testsuite/lib/utils-lib.exp	2018-04-11 22:23:01.494482419 +0100
@@ -224,20 +224,24 @@ proc exe_ext {} {
 #	is useful if several .d files differ by options only.  Options are
 #	always read from FILE.d.
 #
-#   target: GLOBS...
-#       Run this test only on a specified list of targets.  More precisely,
-#       each glob in the space-separated list is passed to "istarget"; if
-#       it evaluates true for any of them, the test will be run, otherwise
-#       it will be marked unsupported.
+#   target: GLOB|PROC ...
+#	Run this test only on a specified list of targets.  More precisely,
+#	in the space-separated list each glob is passed to "istarget" and
+#	each proc is called as a TCL procedure.  List items are interpreted
+#	such that procs are denoted by surrounding square brackets, and any
+#	other items are consired globs.  If the call evaluates true for any
+#	of them, the test will be run, otherwise it will be marked
+#	unsupported.
 #
-#   not-target: GLOBS...
-#       Do not run this test on a specified list of targets.  Again,
-#       the each glob in the space-separated list is passed to
-#       "istarget", and the test is run if it evaluates *false* for
-#       *all* of them.  Otherwise it will be marked unsupported.
+#   not-target: GLOB|PROC ...
+#	Do not run this test on a specified list of targets.  Again, each
+#	glob in the space-separated list is passed to "istarget" and each
+#	proc is called as a TCL procedure, and the test is run if it
+#	evaluates *false* for *all* of them.  Otherwise it will be marked
+#	unsupported.
 #
-#   skip: GLOBS...
-#   not-skip: GLOBS...
+#   skip: GLOB|PROC ...
+#   not-skip: GLOB|PROC ...
 #       These are exactly the same as "not-target" and "target",
 #       respectively, except that they do nothing at all if the check
 #       fails.  They should only be used in groups, to construct a single
@@ -445,13 +449,13 @@ proc run_dump_test { name {extra_options
 	    return
 	}
 	foreach glob $opts(skip) {
-	    if {[istarget $glob]} { return }
+	    if {[match_target $glob]} { return }
 	}
     }
     if { $opts(not-skip) != "" } then {
 	set skip 1
 	foreach glob $opts(not-skip) {
-	    if {[istarget $glob]} {
+	    if {[match_target $glob]} {
 		set skip 0
 		break
 	    }
@@ -461,7 +465,7 @@ proc run_dump_test { name {extra_options
     if { $opts(target) != "" } then {
 	set skip 1
 	foreach glob $opts(target) {
-	    if {[istarget $glob]} {
+	    if {[match_target $glob]} {
 		set skip 0
 		break
 	    }
@@ -473,7 +477,7 @@ proc run_dump_test { name {extra_options
     }
     if { $opts(not-target) != "" } then {
 	foreach glob $opts(not-target) {
-	    if {[istarget $glob]} {
+	    if {[match_target $glob]} {
 		unsupported $testname
 		return
 	    }
Index: binutils/gas/testsuite/lib/gas-defs.exp
===================================================================
--- binutils.orig/gas/testsuite/lib/gas-defs.exp	2018-04-11 17:30:16.402534383 +0100
+++ binutils/gas/testsuite/lib/gas-defs.exp	2018-04-11 22:23:45.442436513 +0100
@@ -383,20 +383,24 @@ proc run_dump_tests { testcases {extra_o
 #	is useful if several .d files differ by options only.  Options are
 #	always read from FILE.d.
 #
-#   target: GLOBS...
-#       Run this test only on a specified list of targets.  More precisely,
-#       each glob in the space-separated list is passed to "istarget"; if
-#       it evaluates true for any of them, the test will be run, otherwise
-#       it will be marked unsupported.
+#   target: GLOB|PROC ...
+#	Run this test only on a specified list of targets.  More precisely,
+#	in the space-separated list each glob is passed to "istarget" and
+#	each proc is called as a TCL procedure.  List items are interpreted
+#	such that procs are denoted by surrounding square brackets, and any
+#	other items are consired globs.  If the call evaluates true for any
+#	of them, the test will be run, otherwise it will be marked
+#	unsupported.
 #
-#   not-target: GLOBS...
-#       Do not run this test on a specified list of targets.  Again,
-#       the each glob in the space-separated list is passed to
-#       "istarget", and the test is run if it evaluates *false* for
-#       *all* of them.  Otherwise it will be marked unsupported.
+#   not-target: GLOB|PROC ...
+#	Do not run this test on a specified list of targets.  Again, each
+#	glob in the space-separated list is passed to "istarget" and each
+#	proc is called as a TCL procedure, and the test is run if it
+#	evaluates *false* for *all* of them.  Otherwise it will be marked
+#	unsupported.
 #
-#   skip: GLOBS...
-#   not-skip: GLOBS...
+#   skip: GLOB|PROC ...
+#   not-skip: GLOB|PROC ...
 #       These are exactly the same as "not-target" and "target",
 #       respectively, except that they do nothing at all if the check
 #       fails.  They should only be used in groups, to construct a single
@@ -575,13 +579,13 @@ proc run_dump_test { name {extra_options
 	    return
 	}
 	foreach glob $opts(skip) {
-	    if {[istarget $glob]} { return }
+	    if {[match_target $glob]} { return }
 	}
     }
     if { $opts(not-skip) != "" } then {
 	set skip 1
 	foreach glob $opts(not-skip) {
-	    if {[istarget $glob]} {
+	    if {[match_target $glob]} {
 		set skip 0
 		break
 	    }
@@ -596,7 +600,7 @@ proc run_dump_test { name {extra_options
 	}
 	set skip 1
 	foreach glob $opts(target) {
-	    if {[istarget $glob]} {
+	    if {[match_target $glob]} {
 		set skip 0
 		break
 	    }
@@ -608,7 +612,7 @@ proc run_dump_test { name {extra_options
     }
     if { $opts(not-target) != "" } then {
 	foreach glob $opts(not-target) {
-	    if {[istarget $glob]} {
+	    if {[match_target $glob]} {
 		unsupported $testname
 		return
 	    }
Index: binutils/ld/testsuite/lib/ld-lib.exp
===================================================================
--- binutils.orig/ld/testsuite/lib/ld-lib.exp	2018-04-11 17:30:16.418648987 +0100
+++ binutils/ld/testsuite/lib/ld-lib.exp	2018-04-11 17:30:20.002273018 +0100
@@ -517,19 +517,26 @@ proc ld_link_defsyms {} {
 #       once.
 #
 #   target: TARGET
-#       Only run the test for TARGET.  This may occur more than once; the
-#       target being tested must match at least one.  You may provide target
-#       name "cfi" for any target supporting the CFI statements.  You may
-#       provide target name "shared" for any target supporting shared
-#       libraries.
+#	Only run the test for TARGET.
+#	You may provide target name "cfi" for any target supporting the
+#	CFI statements.  You may provide target name "shared" for any
+#	target supporting shared libraries.  Otherwise TARGET is called
+#	as a TCL procedure if surrounded by square brackets, or passed
+#	to "istarget" if not.
+#	This may occur more than once; the target being tested must match
+#	at least one.
 #
 #   alltargets: TARGET
-#       Only run the test for TARGET.  This may occur more than once; the
-#       target being tested must match all of them.
+#	Only run the test for TARGET.
+#	The syntax for TARGET is as with 'target'.
+#	This may occur more than once; the target being tested must match
+#	all of them.
 #
 #   notarget: TARGET
-#       Do not run the test for TARGET.  This may occur more than once;
-#       the target being tested must not match any of them.
+#	Do not run the test for TARGET.
+#	The syntax for TARGET is as with 'target'.
+#	This may occur more than once; the target being tested must not
+#	match any of them.
 #
 #   error: REGEX
 #	An error with message matching REGEX must be emitted for the test
@@ -725,7 +732,7 @@ proc run_dump_test { name {extra_options
     if { [llength $opts(target)] > 0 } {
 	set targmatch 0
 	foreach targ $opts(target) {
-	    if [istarget $targ] {
+	    if [match_target $targ] {
 		set targmatch 1
 		break
 	    }
@@ -735,12 +742,12 @@ proc run_dump_test { name {extra_options
 	}
     }
     foreach targ $opts(alltargets) {
-	if ![istarget $targ] {
+	if ![match_target $targ] {
 	    return
 	}
     }
     foreach targ $opts(notarget) {
-	if [istarget $targ] {
+	if [match_target $targ] {
 	    return
 	}
     }