This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] binutils/testsuite: Enable strip-13 test for `hppa*-*'

On Thu, Apr 5, 2018 at 3:55 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Apr 4, 2018 at 1:57 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Apr 4, 2018 at 1:09 PM, Maciej W. Rozycki <macro@mips.com> wrote:
>>> Based on relocations defined in include/elf/*.h files we have relocation
>>> numbers: 143, 159, 214 and 215 currently not used by any of our ELF
>>> targets.  Use 143 then instead of 241 to enable the `strip-13' test for
>>> `hppa*-*' targets.  It has a side effect with some targets of verifying
>>> that unused relocations whose numbers are below the respective R_*_max
>>> value are handled correctly.
>>>
>>>         binutils/
>>>         * testsuite/binutils-all/strip-13.s: Use 143 (0x8f) rather than
>>>         241 (0xf1) for the relocation number and RELA addend.
>>>         * testsuite/binutils-all/strip-13.d: Remove `hppa*-*' from the
>>>         `not-target' list.
>>> ---
>>> Hi,
>>>
>>>  As previously discussed this causes an issue with x86-64 targets and the
>>> R_X86_64_converted_reloc_bit bit added with commit 78984959cb38 ("x86-64:
>>> Add R_X86_64_converted_reloc_bit"), resulting in a test regression.  This
>>> is a bug in the x86-64 target backend, acknowledged by H.J.
>>>
>>
>> I will deal with x86 regressions.
>>
>
> I am testing this patch.
>

I checked it into master.


-- 
H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]