This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/4] x86: correctly encode FSUBP
On Wed, Mar 7, 2018 at 4:36 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 07.03.18 at 13:30, <hjl.tools@gmail.com> wrote:
>> On Wed, Mar 7, 2018 at 1:47 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>> While the combination of Intel syntax and AT&T mnemonics is bogus
>>> anyway, we nevertheless shouldn't mis-encode such insns.
>>>
>>> gas/
>>> 2018-03-07 Jan Beulich <jbeulich@suse.com>
>>>
>>> * testsuite/gas/i386/fsubp.l, testsuite/gas/i386/fsubp.s: New.
>>> * testsuite/gas/i386/i386.exp: Run new test.
>>>
>>> opcodes/
>>> 2018-03-07 Jan Beulich <jbeulich@suse.com>
>>>
>>> * i386-opc.tbl (fsubp): Correct encoding.
>>> * i386-tlb.h: Re-generate.
>>>
>>
>> I assume that no one uses it. Can't we simply drop it?
>
> I don't know, and would dare to chance it. But perhaps you know
> better than me. Of course, if we drop this one, there are others to
> be dropped at the same time.
>
We are changing their encodings. If we can't drop them, it means
that someone is depending on their old encodings.
--
H.J.