This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Use binary search on dynamic relocations
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 5 Mar 2018 12:53:21 +1030
- Subject: Re: [PATCH] Use binary search on dynamic relocations
- Authentication-results: sourceware.org; auth=none
- References: <20180304133054.GA735@intel.com>
On Sun, Mar 04, 2018 at 05:30:54AM -0800, H.J. Lu wrote:
> Replace linear search with binary search on dynamic relocations. After
> finding a match, scan backward to the first matching relocation, then
> scan forward for a matching relocation with non-absolute symbol.
>
> On Fedora 27 x86-64, time for "objdump -d" on libxul.so from RHEL 7.4
> x86-64 went from
>
> 134.46user 0.12system 2:15.03elapsed
>
> to
>
> 8.49user 0.14system 0:08.64elapsed
>
> PR binutils/22911
> * objdump.c (is_significant_symbol_name): Return TRUE for all
> .plt* sections.
> (find_symbol_for_address): Replace linear search with binary
> search on dynamic relocations.
OK, thanks.
--
Alan Modra
Australia Development Lab, IBM