This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [PRU]: Fix disassembly text for instructions with reloc
- From: Dimitar Dimitrov <dimitar at dinux dot eu>
- To: binutils at sourceware dot org
- Cc: Ulrich Weigand <uweigand at de dot ibm dot com>, Nick Clifton <nickc at redhat dot com>
- Date: Fri, 15 Dec 2017 07:04:58 +0200
- Subject: Re: [PATCH] [PRU]: Fix disassembly text for instructions with reloc
- Authentication-results: sourceware.org; auth=none
- Authentication-results: outgoing.host.bg; auth=pass smtp.auth=193 dot 107 dot 36 dot 199 at server28 dot host dot bg
- References: <20171214223614.01268D85C64@oc3748833570.ibm.com>
On четвъртък, 14 декември 2017 г. 23:36:13 EET Ulrich Weigand wrote:
> Nick Clifton wrote:
> > > Could someone commit it? I don't have commit rights.
> >
> > Done.
>
> Looks like this was added at an incorrect location, breaking
> PowerPC disassembly (the bfd_arch_powerpc case no longer falls
> through to the bfd_arch_rs6000 case):
>
> diff --git a/opcodes/disassemble.c b/opcodes/disassemble.c
> index 11206c6..fa9a765 100644
> --- a/opcodes/disassemble.c
> +++ b/opcodes/disassemble.c
> @@ -654,6 +654,11 @@ disassemble_init_for_target (struct disassemble_info *
> info) #ifdef ARCH_powerpc
> case bfd_arch_powerpc:
> #endif
> +#ifdef ARCH_pru
> + case bfd_arch_pru:
> + info->disassembler_needs_relocs = TRUE;
> + break;
> +#endif
> #ifdef ARCH_rs6000
> case bfd_arch_rs6000:
> #endif
>
>
> Bye,
> Ulrich
Hi,
Attached is the obvious fix.
My original mail is applied correctly when I use 'git am'. Do maintainers use
some other workflow for applying patches? How can I, as a patch sender, do
better to avoid breaking binutils?
Regards,
Dimitar
>From 227d38cb86838fb9e872cd03c1f5eab69be50f39 Mon Sep 17 00:00:00 2001
From: Dimitar Dimitrov <dimitar@dinux.eu>
Date: Fri, 15 Dec 2017 06:45:47 +0200
Subject: [PATCH] Fix disassembly for PowerPC
opcodes/
2017-12-15 Dimitar Dimitrov <dimitar@dinux.eu>
* disassemble.c: Put PRU section at right place.
Reported-by: Ulrich Weigand <uweigand@de.ibm.com>
Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
opcodes/disassemble.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/opcodes/disassemble.c b/opcodes/disassemble.c
index fa9a765354..70ee65a1ab 100644
--- a/opcodes/disassemble.c
+++ b/opcodes/disassemble.c
@@ -651,14 +651,14 @@ disassemble_init_for_target (struct disassemble_info * info)
}
break;
#endif
-#ifdef ARCH_powerpc
- case bfd_arch_powerpc:
-#endif
#ifdef ARCH_pru
case bfd_arch_pru:
info->disassembler_needs_relocs = TRUE;
break;
#endif
+#ifdef ARCH_powerpc
+ case bfd_arch_powerpc:
+#endif
#ifdef ARCH_rs6000
case bfd_arch_rs6000:
#endif
--
2.11.0