This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH][GAS][AArch64] Add new fields and operands required for Armv8.4-a [Patch (1/6)]
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: "nickc at redhat dot com" <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "Marcus Shawcroft" <Marcus dot Shawcroft at arm dot com>
- Date: Thu, 9 Nov 2017 11:48:39 +0000
- Subject: RE: [PATCH][GAS][AArch64] Add new fields and operands required for Armv8.4-a [Patch (1/6)]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar dot Christina at arm dot com;
- Nodisclaimer: True
- References: <20171108101055.GA19542@arm.com> <865c7412-030a-7fa7-989e-d1828cf196ff@redhat.com> <d652403c-4fd5-f579-4bd9-e5d71331e1ff@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Hi Nick,
>
> Hi Tamar,
>
> I am very sorry, but I have mucked up. Twice...
>
> Firstly:
>
> >> This patch adds the new Fields and Operand types for the new
> >> instructions in Armv8.4-a.
>
> It was not this patch that triggered the build problem. It was the patch for
> "Retroactively split CRYPTO into AES and SHA2.Q":
>
> https://www.sourceware.org/ml/binutils/2017-11/msg00068.html
>
> Secondly, I committed the patch in that email, even though it did break 32-bit
> builds. Doh. (I should have stayed in bed yesterday).
Yes I noticed this when I was testing the patches, but since it was already committed
I fixed it in the next patch :)
>
> So - I have checked in a supplemental patch to change the underlying type of
> the aarch64_feature_set typedef, which I think is what you wanted.
Yes I just widend aarch64_feature_set, thanks!
>
> Also, the patch for the "Add new fields and operands required for Armv8.4-a
> [Patch (1/6)]"
> submission is approved - so please could it be applied.
>
> Cheers
> Nick
>
> include/ChangeLog
> 2017-11-09 Nick Clifton <nickc@redhat.com>
>
> * opcode/aarch64.h (aarch64_feature_set): Change type to unsigned
> long long.
>
> diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h index
> 325b757b1c..a597ebe0cb 100644
> --- a/include/opcode/aarch64.h
> +++ b/include/opcode/aarch64.h
> @@ -82,7 +82,7 @@ typedef uint32_t aarch64_insn;
> #define AARCH64_ANY AARCH64_FEATURE (-1, 0) /*
> Any basic core. */
>
> /* CPU-specific features. */
> -typedef unsigned long aarch64_feature_set;
> +typedef unsigned long long aarch64_feature_set;
>
> #define AARCH64_CPU_HAS_ALL_FEATURES(CPU,FEAT) \
> ((~(CPU) & (FEAT)) == 0)