This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided

From: Renlin Li <renlin dot li at foss dot arm dot com>
To: Alan Modra <amodra at gmail dot com>
Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
Date: Wed, 25 Oct 2017 11:49:32 +0100
Subject: Re: [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided
Authentication-results: sourceware.org; auth=none
References: <59650B69.3030806@foss.arm.com> <CAMe9rOoYeqs91xnwEj9tcDUZ_PUQGrmKtLb9kcO4gvp0R5t2_g@mail.gmail.com> <59662F7C.7030705@foss.arm.com> <59663072.8070900@foss.arm.com> <59DE41D9.1030505@foss.arm.com> <CAMe9rOogAHhA0oRTXaY9jq-CfXpLmEjPoCQ5W9vLHgFyT7dzsg@mail.gmail.com> <59DF6B01.7090004@foss.arm.com> <CAMe9rOprmJgwxd8LLn1RGpqw9_ER8fWcu0E-ybRPbSX5-4YmwA@mail.gmail.com> <59E60B84.50707@foss.arm.com> <20171024093443.GG27132@bubble.grove.modra.org> <20171025041612.GI27132@bubble.grove.modra.org>

Hi Alan,

Thank you for your information. I am looking into it right now!

Regards,
Renlin

On 25/10/17 05:16, Alan Modra wrote:

On Tue, Oct 24, 2017 at 08:04:43PM +1030, Alan Modra wrote:

On Tue, Oct 17, 2017 at 02:54:12PM +0100, Renlin Li wrote:

bfd/ChangeLog:

2017-10-17  Renlin Li  <renlin.li@arm.com>

	* elflink.c (_bfd_elf_merge_symbol): Handle multiple definition case.

ld/ChangeLog:

2017-10-17  Renlin Li  <renlin.li@arm.com>

	* testsuite/ld-elf/elf.exp: Run new tests.
	* testsuite/ld-elf/pr21703-1.s: New.
	* testsuite/ld-elf/pr21703-2.s: New.
	* testsuite/ld-elf/pr21703-3.s: New.
	* testsuite/ld-elf/pr21703-4.s: New.
	* testsuite/ld-elf/pr21703-r.sd: New.
	* testsuite/ld-elf/pr21703-shared.sd: New.
	* testsuite/ld-elf/pr21703.sd: New.
	* testsuite/ld-elf/pr21703.ver: New.

OK.


It looks like you have some work to do on this testcase.  Please
investigate.  One obvious thing is not run the -shared test for ELF
targets without shared library support.  You also probably should
exclude targets that use _bfd_generic_link_add_symbols (those that
don't define elf_backend_relocate_section).

avr-elf  +FAIL: PR ld/21703 -r
avr-elf  +FAIL: PR ld/21703 shared
cr16-elf  +FAIL: PR ld/21703 -r
cr16-elf  +FAIL: PR ld/21703 shared
cris-elf  +FAIL: PR ld/21703 shared
crx-elf  +FAIL: PR ld/21703 -r
crx-elf  +FAIL: PR ld/21703 shared
d10v-elf  +FAIL: PR ld/21703 shared
d30v-elf  +FAIL: PR ld/21703
d30v-elf  +FAIL: PR ld/21703 -r
d30v-elf  +FAIL: PR ld/21703 shared
dlx-elf  +FAIL: PR ld/21703
dlx-elf  +FAIL: PR ld/21703 -r
dlx-elf  +FAIL: PR ld/21703 shared
epiphany-elf  +FAIL: PR ld/21703 shared
fr30-elf  +FAIL: PR ld/21703 shared
frv-elf  +FAIL: PR ld/21703 shared
ft32-elf  +FAIL: PR ld/21703 -r
ft32-elf  +FAIL: PR ld/21703 shared
h8300-elf  +FAIL: PR ld/21703 shared
hppa64-hp-hpux11.23  +FAIL: PR ld/21703 shared
hppa64-linux  +FAIL: PR ld/21703 shared
ip2k-elf  +FAIL: PR ld/21703 shared
iq2000-elf  +FAIL: PR ld/21703 shared
lm32-elf  +FAIL: PR ld/21703 shared
m32c-elf  +FAIL: PR ld/21703 shared
m32r-elf  +FAIL: PR ld/21703 shared
m68hc11-elf  +FAIL: PR ld/21703 shared
m68hc12-elf  +FAIL: PR ld/21703 shared
mcore-elf  +FAIL: PR ld/21703 shared
mep-elf  +FAIL: PR ld/21703 -r
mep-elf  +FAIL: PR ld/21703 shared
microblaze-elf  +FAIL: PR ld/21703 -r
microblaze-elf  +FAIL: PR ld/21703 shared
mipstx39-elf  +FAIL: PR ld/21703 shared
mn10200-elf  +FAIL: PR ld/21703 shared
moxie-elf  +FAIL: PR ld/21703 shared
ms1-elf  +FAIL: PR ld/21703 shared
msp430-elf  +FAIL: PR ld/21703 -r
msp430-elf  +FAIL: PR ld/21703 shared
mt-elf  +FAIL: PR ld/21703 shared
nds32le-elf  +FAIL: PR ld/21703 shared
or1k-elf  +FAIL: PR ld/21703 shared
pj-elf  +FAIL: PR ld/21703
pj-elf  +FAIL: PR ld/21703 -r
pj-elf  +FAIL: PR ld/21703 shared
pru-elf  +FAIL: PR ld/21703 -r
pru-elf  +FAIL: PR ld/21703 shared
rl78-elf  +FAIL: PR ld/21703 -r
rl78-elf  +FAIL: PR ld/21703 shared
rx-elf  +FAIL: PR ld/21703 shared
spu-elf  +FAIL: PR ld/21703 shared
tic6x-elf  +FAIL: PR ld/21703 shared
v850-elf  +FAIL: PR ld/21703 shared
visium-elf  +FAIL: PR ld/21703 shared
xgate-elf  +FAIL: PR ld/21703 shared
xstormy16-elf  +FAIL: PR ld/21703 shared

References:
- Re: [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided
  - From: Renlin Li
- Re: [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided
  - From: H.J. Lu
- Re: [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided
  - From: Renlin Li
- Re: [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided
  - From: H.J. Lu
- Re: [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided
  - From: Renlin Li
- Re: [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided
  - From: Alan Modra
- Re: [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]