This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix typos in previous ld testsuite: it's istarget, not is_target
- From: Palmer Dabbelt <palmer at dabbelt dot com>
- To: hans-peter dot nilsson at axis dot com, christophe dot lyon at linaro dot org
- Cc: binutils at sourceware dot org, Andrew Waterman <andrew at sifive dot com>
- Date: Tue, 24 Oct 2017 15:58:13 -0700 (PDT)
- Subject: Re: Fix typos in previous ld testsuite: it's istarget, not is_target
- Authentication-results: sourceware.org; auth=none
On Tue, 24 Oct 2017 15:54:42 PDT (-0700), hans-peter.nilsson@axis.com wrote:
> My autotester got:
>
> Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp ...
> ERROR: (DejaGnu) proc "is_target riscv-*-*" does not exist.
> The error code is NONE
> The info on the error is:
> invalid command name "is_target"
> while executing
> "::tcl_unknown is_target riscv-*-*"
> ("uplevel" body line 1)
> invoked from within
> "uplevel 1 ::tcl_unknown $args"
>
> Not sure why you didn't see this in your own testing. Does
> newer dejagnu have is_target as an alias for istarget? BTW, I
> fixed the format typos in your ChangeLog entries: the path is
> always relative to the directory of the ChangeLog file.
>
> ld:
> * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Fix typo for istarget.
>
> diff --git a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
> index efe012e..c219b18 100644
> --- a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
> +++ b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
> @@ -19,6 +19,6 @@
> # MA 02110-1301, USA.
> #
>
> -if [is_target "riscv-*-*"] {
> +if [istarget "riscv-*-*"] {
> run_dump_test "c-lui"
> }
>
> Also (no ChangeLog entries for ChangeLog edits):
>
> index a0508fe..368a496 100644
> --- a/ld/ChangeLog
> +++ b/ld/ChangeLog
> @@ -4,9 +4,9 @@
>
> 2017-10-24 Andrew Waterman <andrew@sifive.com>
>
> - * ld/testsuite/ld-riscv-elf/c-lui.d: New testcase.
> - ld/testsuite/ld-riscv-elf/c-lui.s: Likewise.
> - ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp: New test suite.
> + * testsuite/ld-riscv-elf/c-lui.d: New testcase.
> + * testsuite/ld-riscv-elf/c-lui.s: Likewise.
> + * testsuite/ld-riscv-elf/ld-riscv-elf.exp: New test suite.
>
> 2017-10-24 Renlin Li <renlin.li@arm.com>
>
> brgds, H-P
Thanks. I had this floating around
https://cygwin.com/ml/binutils/2017-10/msg00386.html
but I missed the ChangeLog formatting problem.