This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 05/12] mips: Check UNDEFWEAK_NO_DYNAMIC_RELOC
- From: "Maciej W. Rozycki" <macro at mips dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Alan Modra <amodra at gmail dot com>, <binutils at sourceware dot org>
- Date: Wed, 18 Oct 2017 20:24:48 +0100
- Subject: Re: [PATCH 05/12] mips: Check UNDEFWEAK_NO_DYNAMIC_RELOC
- Authentication-results: sourceware.org; auth=none
- References: <20171012131007.27554-1-hjl.tools@gmail.com> <20171012131007.27554-6-hjl.tools@gmail.com>
On Thu, 12 Oct 2017, H.J. Lu wrote:
> diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c
> index 6a4d3e1a6a..23fba1bbe0 100644
> --- a/bfd/elfxx-mips.c
> +++ b/bfd/elfxx-mips.c
> @@ -5665,6 +5666,10 @@ mips_elf_calculate_relocation (bfd *abfd, bfd *input_bfd,
> addend = 0;
> }
>
> + resolved_to_zero = (h != NULL
> + && UNDEFWEAK_NO_DYNAMIC_RELOC (info,
> + &h->root));
Gratuitous line wrapping.
I can see you have checked it in last Sat despite Alan's request to wait
a few days to give target maintainers an opportunity to chime in. Please
don't do this again. Not everyone works weekends.
I'll look through the change yet and see if there are any issues beyond
mere formatting nits.
Maciej