This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix fill-1 testcase


This fixes various issues with the fill-1 testcase causing fails on a
couple of targets.

Ok for mainline?

gas/ChangeLog:

2017-10-18  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>

	* testsuite/gas/all/fill-1.s: Use normal labels.  Change .text to
	.data. Pick different values.  Use .dc.w instead of .word.
	* testsuite/gas/all/fill-1.d: New objdump output check.
	* testsuite/gas/all/gas.exp: Use run_dump_test to execute fill-1
	testcase.
---
 gas/testsuite/gas/all/fill-1.d |  7 +++++++
 gas/testsuite/gas/all/fill-1.s | 12 +++++++-----
 gas/testsuite/gas/all/gas.exp  |  2 +-
 3 files changed, 15 insertions(+), 6 deletions(-)
 create mode 100644 gas/testsuite/gas/all/fill-1.d

diff --git a/gas/testsuite/gas/all/fill-1.d b/gas/testsuite/gas/all/fill-1.d
new file mode 100644
index 0000000..da5933e
--- /dev/null
+++ b/gas/testsuite/gas/all/fill-1.d
@@ -0,0 +1,7 @@
+#objdump: -s -j .data -j "\$DATA\$"
+#name: fill test with forward labels
+
+.*: +file format .*
+
+Contents of section (\.data|\$DATA\$):
+ [^ ]* 0a0a0d0d 0b0b0c0c .*
diff --git a/gas/testsuite/gas/all/fill-1.s b/gas/testsuite/gas/all/fill-1.s
index e72cbf1..34c52cc 100644
--- a/gas/testsuite/gas/all/fill-1.s
+++ b/gas/testsuite/gas/all/fill-1.s
@@ -1,5 +1,7 @@
-	.text
-	.fill (2f-1f), 1, 0x90
-1:
-        .word 42
-2:
+	.data
+	.dc.w 0x0a0a
+	.fill (.L2-.L1), 1, 0x0d
+.L1:
+	.dc.w 0x0b0b
+.L2:
+	.dc.w 0x0c0c
diff --git a/gas/testsuite/gas/all/gas.exp b/gas/testsuite/gas/all/gas.exp
index 93e31da..1810ef4 100644
--- a/gas/testsuite/gas/all/gas.exp
+++ b/gas/testsuite/gas/all/gas.exp
@@ -487,4 +487,4 @@ run_dump_test "org-4"
 run_dump_test "org-5"
 run_dump_test "org-6"
 
-gas_test "fill-1.s" "" "" "test .fill forward label references"
+run_dump_test "fill-1"
-- 
2.9.1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]