This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFC] .fill does not accept forward labels
On Mon, 16 Oct 2017, Andreas Krebbel wrote:
> > > > It revealed failures for these targets:
> > > >
> > > > hppa-hp-hpux10 +FAIL: fill test with forward labels
> > > > hppa64-hp-hpux11.23 +FAIL: fill test with forward labels
> > > > ia64-vms +FAIL: fill test with forward labels
> > > > sh-pe +FAIL: fill test with forward labels
> > > > tic4x-coff +FAIL: fill test with forward labels
> > > > tic54x-coff +FAIL: fill test with forward labels
>
> With that one the first 4 fails go away. The last two occur also with .skip.
Thanks for checking. I'd leave them as they are then, for someone
actually interested to analyse.
> new file mode 100644
> index 0000000..a9ee853
> --- /dev/null
> +++ b/gas/testsuite/gas/all/fill-1.d
> @@ -0,0 +1,8 @@
> +#objdump: -s -j .data -j "\$DATA\$"
> +#name: fill test with forward labels
> +
> +.*: +file format .*
> +
> +Contents of section (\.data|\$DATA\$):
> + [^ ]* 0a0a0d0d 0b0b0c0c .*
> +
Extraneous new line. I've smoke-tested your change with a single MIPS
target only, with no issues observed. Otherwise I have no further input
and thus I'm leaving your change for a general maintainer to approve.
Maciej