Re: [PATCH 0/4][MSP430] Improve behaviour of ".either" section placement

[Jozef Lawrynowicz <jozef dot l at somniumtech dot com>]

On 20/07/2017 13:36, Nick Clifton wrote:
> Rather than comment on each patch individually I have some general
comments
> that apply to all of the patches:
>
>   * Please could you provide ChangeLog entries for each of the patches.
>
>   * Please move variable declarations to the start of their containing
>     blocks.  I know that modern C compilers allow them anywhere in the
>     block, but we still need to support some older compilers that do not.
>
>   * Please used ATTRIBUTE_UNUSED instead of __attribute__((unused)).
>
>   * Please format comments according to the GNU coding standard.
>     Specifically a comment like this:
>
>       /* This is a
>        * multiline comment.
>        */
>
>     Should be formatted as:
>
>      /* This is a
>         multiline comment.  */
>
> Also, there is one specific comments on the behaviour of patch series:
>
>   * It seems to me that when performing the last UPPER to LOWER move it
>     would be better to move any section that will fit into LOWER, even
>     if UPPER is *not* overflowing.  This assumes that LOWER memory is 
faster
>     and hence it is preferable to use as much of it as possible.

Thanks for the reply Nick, and apologies for the delay in replying. I've
updated the patches with your advice. It was a good point about filling
the lower region as much as possible, even when upper is not
overflowing, so have made that change as well.

The updated patches are attached.
I will be posting an accompanying patch to gcc-patches which propagates
the -mcode/data-region options to the assembler and linker, which is
necessary to actually make this new functionality useful.

Thanks,
Jozef

Attachment: 0001-MSP430-Add-feature-to-add-lower-either-upper-prefixe.patch
Description: Text document

Attachment: 0002-MSP430-Change-.either-section-placement-to-be-perfor.patch
Description: Text document

Attachment: 0003-MSP430-Remove-.either-placement-code-from-place_orph.patch
Description: Text document

Attachment: 0004-MSP430-Define-symbols-to-initialise-high-data-and-hi.patch
Description: Text document