This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Support %Lx, %Lu, %Ld in _bfd_error_handler format

On Thu, Jul 06, 2017 at 06:50:18AM -0700, H.J. Lu wrote:
> This is incomplete and breaks 32-bit bfd_vma.  I am checking in
> 
> diff --git a/bfd/bfd.c b/bfd/bfd.c
> index b6cdf3f..a119ac4 100644
> --- a/bfd/bfd.c
> +++ b/bfd/bfd.c
> @@ -727,7 +727,10 @@ _doprnt (FILE *stream, const char *format, va_list ap)
>              either long long or long.  */
>           if ((BFD_ARCH_SIZE < 64 || BFD_HOST_64BIT_LONG)
>          && sptr[-2] == 'L')
> -           wide_width = 1;
> +           {
> +        wide_width = 1;
> +        sptr[-2] = 'l';
> +           }
> 
>           switch (wide_width)
> 
> to fix it.

Thanks.  Hmm, maybe "L" should be changed to "ll" for long long too.

-- 
Alan Modra
Australia Development Lab, IBM
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]