This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [AArch64] Use SYMBOL_REFERENCES_LOCAL in one symbol check

From: Steve Ellcey <sellcey at cavium dot com>
To: Jiong Wang <jiong dot wang at foss dot arm dot com>, Binutils <binutils at sourceware dot org>, Nick Clifton <nickc at redhat dot com>
Date: Wed, 21 Jun 2017 11:05:49 -0700
Subject: Re: [AArch64] Use SYMBOL_REFERENCES_LOCAL in one symbol check
Authentication-results: sourceware.org; auth=none
Authentication-results: foss.arm.com; dkim=none (message not signed) header.d=none;foss.arm.com; dmarc=none action=none header.from=cavium.com;
References: <176b0351-5a7d-0b67-2228-8825c9247fc9@foss.arm.com> <1497981047.31950.46.camel@cavium.com> <1497999026.31950.53.camel@cavium.com> <3a23019f-5946-818b-90fc-203164606931@foss.arm.com>
Reply-to: sellcey at cavium dot com
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

On Wed, 2017-06-21 at 11:00 +0100, Jiong Wang wrote:
> 
>            
>    So, I think we should fix AArch64 glibc code, to use _GI__dl_argv instead of
> _dl_argv,
>                      
>     ...
>     adrp    x3, __GI__dl_argv                                       \n\
>     str     " PTR "2, [x3, #:lo12:__GI__dl_argv]                    \n\
>     ...
>            
>   This seems to me is the correct way, and I verified glibc build should be OK after
> this change.


Thanks Jiong,  this patch works for me too and I see that Szabolcs Nagy
has checked this change into the glibc source tree.

Steve Ellcey
sellcey@cavium.com

References:
- [AArch64] Use SYMBOL_REFERENCES_LOCAL in one symbol check
  - From: Jiong Wang
- Re: [AArch64] Use SYMBOL_REFERENCES_LOCAL in one symbol check
  - From: Steve Ellcey
- Re: [AArch64] Use SYMBOL_REFERENCES_LOCAL in one symbol check
  - From: Steve Ellcey
- Re: [AArch64] Use SYMBOL_REFERENCES_LOCAL in one symbol check
  - From: Jiong Wang

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]