This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, objcopy] Fix objcopy quadratic-time when handling --redefine-syms

From: Jiong Wang <jiong dot wang at foss dot arm dot com>
To: Pedro Alves <palves at redhat dot com>, Binutils <binutils at sourceware dot org>
Date: Thu, 6 Apr 2017 09:57:59 +0100
Subject: Re: [Patch, objcopy] Fix objcopy quadratic-time when handling --redefine-syms
Authentication-results: sourceware.org; auth=none
References: <65d8aa4f-2138-629b-e89c-f04946bd1d50@foss.arm.com> <1f90bff1-fa12-a19a-5a5d-db43906c374f@redhat.com>

On 06/04/17 09:51, Pedro Alves wrote:

On 04/06/2017 09:43 AM, Jiong Wang wrote:


There is no regression on check-binutils after this patch, although I found
there is actually no check on redefine symbol feature in binutils testsuite.

So I also tested this patch on several manually written testcases which were

trying to rename some symbols, they works fine.

Could those manually written tests be converted to real testsuite tests?


They could.

I was using the automatically generated redefine file listed in this email, then inserted some
valid renaming pair in some random places, and was checking the symbols are really renamed in the
final output file.

References:
- [Patch, objcopy] Fix objcopy quadratic-time when handling --redefine-syms
  - From: Jiong Wang
- Re: [Patch, objcopy] Fix objcopy quadratic-time when handling --redefine-syms
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]