This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] RISC-V: Resurrect GP-relative disassembly hints
- From: Nick Clifton <nickc at redhat dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 4 Apr 2017 11:48:04 +0100
- Subject: Re: [PATCH] RISC-V: Resurrect GP-relative disassembly hints
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7CF107D0D7
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7CF107D0D7
- References: <mhng-39981695-5056-4041-b490-337c888c8bae@palmer-si-x1c4>
Hi Palmer,
>> Wouldn't it be better to use the GP_NAME define value ? (Currently in bfd/elfnn-risc.c,
>> but it ought to be moved into a header file, eg include/elf/riscv.h).
>
> Yes, it definitely would. I guess I just forgot we'd done that. How does this
> look?
Much better - approved - please apply.
Cheers
Nick