This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [WebAssembly] Skeleton support


Hi Pip,

>>> +    {
>>> +      if (bfd_get_error () != bfd_error_file_truncated)
>>> +        *errorptr = TRUE;
>>> +      return FALSE;
>>> +    }
>>
>> Why is it not an error if the read failed for some reason other than file
>> truncation ?
> 
> I may be misreading the code; the intention is that *errorptr is set
> to TRUE, indicating an error, for all reasons except for file
> truncation, which indicates EOF, which is not an error if we're done
> with the last section.

Thanks - I misspoke, or mis-typed if you prefer.  The code does make
sense now that I am thinking clearly.

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]