This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [WebAssembly] Skeleton support
- From: Nick Clifton <nickc at redhat dot com>
- To: Pip Cet <pipcet at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 27 Mar 2017 11:22:17 +0100
- Subject: Re: [PATCH] [WebAssembly] Skeleton support
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C9AB0C04B938
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C9AB0C04B938
- References: <CAOqdjBfO29Yc09f22B4u61E2cjSBwpya8=phePCAgHTdArTPYQ@mail.gmail.com> <6ba7849d-2475-587d-d4a9-6e67c7df550b@redhat.com> <CAOqdjBcbL8-_KwufBPb96V6d0hh_QT6Sx2-tdWXu==qbUpRRZg@mail.gmail.com>
Hi Pip,
>>> + {
>>> + if (bfd_get_error () != bfd_error_file_truncated)
>>> + *errorptr = TRUE;
>>> + return FALSE;
>>> + }
>>
>> Why is it not an error if the read failed for some reason other than file
>> truncation ?
>
> I may be misreading the code; the intention is that *errorptr is set
> to TRUE, indicating an error, for all reasons except for file
> truncation, which indicates EOF, which is not an error if we're done
> with the last section.
Thanks - I misspoke, or mis-typed if you prefer. The code does make
sense now that I am thinking clearly.
Cheers
Nick