This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Add SFENCE.VMA instruction
- From: Palmer Dabbelt <palmer at dabbelt dot com>
- To: nickc at redhat dot com
- Cc: binutils at sourceware dot org
- Cc: Tristan Gingold <gingold at adacore dot com>
- Cc: Andrew Waterman <andrew at sifive dot com>
- Date: Wed, 15 Feb 2017 10:39:23 -0800 (PST)
- Subject: Re: [PATCH] Add SFENCE.VMA instruction
- Authentication-results: sourceware.org; auth=none
On Wed, 15 Feb 2017 03:33:40 PST (-0800), nickc@redhat.com wrote:
> Hi Palmer,
>
>> include/ChangeLog:
>> 2017-02-14 Andrew Waterman <andrew@sifive.com>
>>
>> * opcode/riscv-opc.h (MATCH_SFENCE_VMA): New define.
>> (MASK_SFENCE_VMA): Likewise.
>> (sfence_vma): Declare instruction.
>>
>> opcodes/ChangeLog:
>> 2017-02-14 Andrew Waterman <andrew@sifive.com>
>>
>> * riscv-opc.c (riscv_opcodes): Add sfence.vma instruction and
>> pseudoinstructions.
>
> OK for trunk.
Thanks!
>> diff --git a/include/ChangeLog b/include/ChangeLog
>> index 6a61d61..df14aca 100644
>> --- a/include/ChangeLog
>> +++ b/include/ChangeLog
>> @@ -1,3 +1,9 @@
>> +2017-02-14 Andrew Waterman <andrew@sifive.com>
>> +
>> + * opcode/riscv-opc.h (MATCH_SFENCE_VMA): New define.
>> + (MASK_SFENCE_VMA): Likewise.
>> + (sfence_vma): Declare instruction.
>> +
>
> Note - it is customary to include ChangeLog entries as plain text rather
> than context diffs. This is because the changelogs change so rapidly that
> it is often not possible to apply a patch cleanly if they contain changelog
> diffs.
I've been using "git-merge-changelog" to merge my ChangeLog entries and haven't
had a merge conflict yet. If you'd like I can drop them from the mailing list
posts, but it's slightly easier for me to keep everything together.