Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode

[Nick Clifton <nickc at redhat dot com>]

Hi Yuri,

> I ran 'make check-ld' for tests, and I thought that's enough.

Not really - you should also check the gas and binutils testsuites too.
A change in the BFD library can affect these tests too.  (It does not
matter now though, as I have run the regressions tests myself and there
were no problems).

> With changed configure options I see that site.exp is changed
> accordingly, so I think I don't need to change it manually. Is it
> correct?

Yes.

>> [1] You can do this in the site.exp file with an entry like this:
>>
>>    { "aarch64-*" "aarch64_be-*" } {
>> 	set target_list "aarch64-sim{-mabi=ilp32}"
>> 	set ASFLAGS "-mabi=ilp32"
>>     }
> 
> Regarding forced -mabi=ilp32 option, most probably I didn't understand
> what you mean.  set target_list "aarch64-sim{-mabi=ilp32}" simply doesn't work:
> 
>                         === ld tests ===
> 
>         Schedule of variations:
>             aarch64-sim/-mabi=ilp32
> 
>         Running target aarch64-sim/-mabi=ilp32
>         ERROR: couldn't load description file for aarch64-sim

Ah - you are doubtless running on real AArch64 hardware.  I have been using a sim
(and configuring dejagnu to support the sim).  So you need to edit the 'set target_
list' line to match how your normal site.exp works.  Again though this does not 
matter now as I have already done the testing.


>  bfd/ChangeLog                                      |   4 +
>  bfd/elfnn-aarch64.c                                | 184 ++++++++++++---------
>  ld/ChangeLog                                       |  16 ++
>  ld/testsuite/ld-aarch64/aarch64-elf.exp            |  14 +-
>  ld/testsuite/ld-aarch64/tls-desc-ie-ilp32.d        |  37 +++++
>  ld/testsuite/ld-aarch64/tls-relax-all-ilp32.d      |  40 +++++
>  ld/testsuite/ld-aarch64/tls-relax-gd-le-ilp32.d    |  10 ++
>  .../ld-aarch64/tls-relax-gdesc-le-2-ilp32.d        |  19 +++
>  ld/testsuite/ld-aarch64/tls-relax-gdesc-le-ilp32.d |  12 ++
>  ld/testsuite/ld-aarch64/tls-relax-ie-le-2-ilp32.d  |  18 ++
>  ld/testsuite/ld-aarch64/tls-relax-ie-le-3-ilp32.d  |  10 ++
>  ld/testsuite/ld-aarch64/tls-relax-ie-le-ilp32.d    |  10 ++
>  ld/testsuite/ld-aarch64/tls-tiny-desc-ie-ilp32.d   |  12 ++
>  ld/testsuite/ld-aarch64/tls-tiny-desc-le-ilp32.d   |  12 ++
>  ld/testsuite/ld-aarch64/tls-tiny-gd-ie-ilp32.d     |  12 ++
>  ld/testsuite/ld-aarch64/tls-tiny-gd-le-ilp32.d     |  12 ++

Anyway - the patch is approved and I have taken the liberty of applying it
for you, since it was already in my local sources.

Cheers
  Nick