This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD] Propagate error status from awk in tests
- From: "Rahul Chaudhry via binutils" <binutils at sourceware dot org>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>, Cary Coutant <ccoutant at gmail dot com>
- Date: Mon, 9 Jan 2017 17:25:21 -0800
- Subject: Re: [GOLD] Propagate error status from awk in tests
- Authentication-results: sourceware.org; auth=none
- References: <CAJRD=ortygKw53tKhHG8HnFUJucrmeQhPpax-soqy16KGVhQXQ@mail.gmail.com> <CAKOQZ8zbnRgOi3=esGcnC66FP-uRezSXqTFhYZiq0S_MOjpdRA@mail.gmail.com>
- Reply-to: Rahul Chaudhry <rahulchaudhry at google dot com>
The tests I was having problem with didn't have "set -e".
Please ignore this patch. I'll send another one to enable
"set -e" in test scripts that have it missing.
Thanks,
Rahul
On Mon, Jan 9, 2017 at 3:14 PM, Ian Lance Taylor <iant@google.com> wrote:
> On Mon, Jan 9, 2017 at 3:05 PM, Rahul Chaudhry via binutils
> <binutils@sourceware.org> wrote:
>> Some tests in gold/testsuite/ run awk to check for errors.
>> The awk scripts use "exit 1" to indicate test failure, but
>> the shell scripts didn't check for the exit status from awk.
>> This patch adds the checks so failing tests actually fail.
>
> In general the shell scripts use `set -e` to pick up failures in
> programs that they run. Why isn't that working here?
>
> Ian