This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Don't fudge p_vaddr when PHDR in segment

From: Alan Modra <amodra at gmail dot com>
To: DJ Delorie <dj at redhat dot com>
Cc: binutils at sourceware dot org
Date: Tue, 13 Dec 2016 12:04:48 +1030
Subject: Re: Don't fudge p_vaddr when PHDR in segment
Authentication-results: sourceware.org; auth=none
References: <20161212230625.GV10584@bubble.grove.modra.org> <xnfulsafbx.fsf@greed.delorie.com>

On Mon, Dec 12, 2016 at 06:38:10PM -0500, DJ Delorie wrote:
> 
> I would be extremely careful changing any RX logic without thorough
> testing on both gdb and RX debuggers (on both sim and hw), and both gcc
> and RX compilers.  It took many iterations to get it all to work
> reliably everywhere.

I'm fairly certain my patch will do no harm.  See the comment I added.
However, if you're worried go ahead and revert it.  I guarantee I
won't be upset (but I might laugh when someone complains about wrong
LMAs for RX in the future).

The patch came about due to some mild concern over adding
SIZEOF_HEADERS recently to some testsuite linker scripts, and
looking into the effect on targets that don't use SIZEOF_HEADERS in
their standard scripts.

-- 
Alan Modra
Australia Development Lab, IBM

References:
- Don't fudge p_vaddr when PHDR in segment
  - From: Alan Modra
- Re: Don't fudge p_vaddr when PHDR in segment
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]