This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2 2/7] gas/arc: Replace short_insn flag with insn length field
- From: Nick Clifton <nickc at redhat dot com>
- To: Graham Markall <graham dot markall at embecosm dot com>, binutils at sourceware dot org
- Cc: claudiu dot zissulescu at synopsys dot com, noamca at mellanox dot com, rinat at mellanox dot com, guybe at mellanox dot com, andrew dot burgess at embecosm dot com
- Date: Thu, 3 Nov 2016 16:29:01 +0000
- Subject: Re: [PATCH v2 2/7] gas/arc: Replace short_insn flag with insn length field
- Authentication-results: sourceware.org; auth=none
- References: <cover.1477580390.git.graham.markall@embecosm.com> <54b2c600b2f312075b7bb99134d3bfcd9ba298de.1477580390.git.graham.markall@embecosm.com>
Hi Graham,
> gas/ChangeLog:
>
> * config/tc-arc.c (struct arc_insn): Replace short_insn flag with
> len field.
> (apply_fixups): Update to use len field.
> (emit_insn0): Simplify code, making use of len field.
> (md_convert_frag): Update to use len field.
> (assemble_insn): Update to use len field.
Approved - please apply. Although I do have one small question:
> long limm;
> - bfd_boolean short_insn; /* Boolean value: TRUE if current insn is
> - short. */
> + int len; /* Length of instruction in bytes. */
Can the length be negative ? If not then maybe "unsigned int" would be more appropriate.
Cheers
Nick