This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 5/7] RISC-V GAS Port
- From: Nick Clifton <nickc at redhat dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>, Andrew Waterman <andrew at sifive dot com>, binutils at sourceware dot org
- Date: Tue, 1 Nov 2016 12:46:02 +0000
- Subject: Re: [PATCH 5/7] RISC-V GAS Port
- Authentication-results: sourceware.org; auth=none
- References: <1477179037-32066-1-git-send-email-palmer@dabbelt.com> <1477179037-32066-6-git-send-email-palmer@dabbelt.com>
Hi Palmer,
Just noticed this:
> diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
[...]
> +/* Pseudo-op table. */
> +static const pseudo_typeS riscv_pseudo_table[] =
> + {"p2align", s_align, 0},
This breaks one of the gas testsuite's tests (gas/testsuite/gas/all/align.s)
because it does not support the third argument to the normal
.p2align pseudo-op. It also means that .p2align pseudo-op does
not behave as documented when the target is the riscv.
Please could you consider extending your s_align() function to
handle the extra argument.
Cheers
Nick