This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/6] RISC-V opcodes

From: Nick Clifton <nickc at redhat dot com>
To: Andrew Waterman <palmer at dabbelt dot com>, binutils at sourceware dot org
Cc: Andrew Waterman <andrew at sifive dot com>
Date: Fri, 14 Oct 2016 15:39:57 +0100
Subject: Re: [PATCH 4/6] RISC-V opcodes
Authentication-results: sourceware.org; auth=none
References: <1476229571-22422-1-git-send-email-andrew@sifive.com> <1476229571-22422-5-git-send-email-andrew@sifive.com>

Hi Andrew,

> +++ b/include/opcode/riscv-opc.h
> @@ -0,0 +1,1160 @@
> +/* Automatically generated by parse-opcodes */

If this file is generated by a tool, then that tool (and input files it
requires) should be part of the submission too.  Either that, or else
these generated files should be changed to be considered to be the 
originals, and no generator mentioned or needed.

The actual patch itself looks reasonably to me, although I have not
yet tested it in a real build.  (I am waiting until all of the patches
have been reviewed and, if necessary, updated).

Cheers
  Nick

Follow-Ups:
- Re: [PATCH 4/6] RISC-V opcodes
  - From: Palmer Dabbelt

References:
- Binutils/gas/ld port for RISC-V
  - From: Andrew Waterman
- [PATCH 4/6] RISC-V opcodes
  - From: Andrew Waterman

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]