This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING PATCH] arc: Fix segfault when generating got entries for local symbols


Hi Nick,

Please notice this patch was not mine. :-(
For good or for bad, I do not want to take any credit for someone else
patch.

I just sent the email, because that patch really solves a problem in the
code and seemed forgotten in the list.

Thanks a lot,
Cupertino

On 07/22/2016 04:15 PM, Nick Clifton wrote:
> Hi Cupertino,
>
>> This patch is still needing approval by someone.
>> Nick: Do you approve and apply, perhaps ? :-)
> :)
>
>>> bfd/ChangeLog:
>>>
>>> 	* arc-got.h (relocate_fix_got_relocs_for_got_info): Handle the case
>>> 	where there's no elf_link_hash_entry while processing GOT_NORMAL got
>>> 	entries.
>>>
>>> ld/ChangeLog:
>>>
>>> 	* testsuite/ld-arc/got-01.d: New file.
>>> 	* testsuite/ld-arc/got-01.s: New file.
>  
> Approved and applied.
>
> Note - you missed one small detail.  The new test failed on a target
> configured as arc-linux-uclibc.  (Because there are only 7 entries in
> section headers, not 9).  I have taken the liberty of fixing this for
> you, but in the future I would recommend testing patches on a variety
> of different ARC target configurations.
>
> Cheers
>   Nick
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]