This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 3/6] Fetch the ELF auxiliary vector from live processes on FreeBSD.
- From: Pedro Alves <palves at redhat dot com>
- To: John Baldwin <jhb at FreeBSD dot org>, gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Tue, 21 Jun 2016 00:01:43 +0100
- Subject: Re: [PATCH 3/6] Fetch the ELF auxiliary vector from live processes on FreeBSD.
- Authentication-results: sourceware.org; auth=none
- References: <20160616060202 dot 63470-1-jhb at FreeBSD dot org> <20160616060202 dot 63470-4-jhb at FreeBSD dot org>
On 06/16/2016 07:01 AM, John Baldwin wrote:
> +static enum target_xfer_status
> +fbsd_xfer_partial (struct target_ops *ops, enum target_object object,
"Implement foo"-style intro comment missing.
> + switch (object)
> + {
> + case TARGET_OBJECT_AUXV:
> + {
> + struct cleanup *cleanup = make_cleanup (null_cleanup, NULL);
> + unsigned char *buf;
> + size_t buflen;
> + int mib[4];
> +
> + if (writebuf)
writebuf != NULL.
Otherwise LGTM.
Thanks,
Pedro Alves