This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, ppc] Allow IMM8 operands to accept both signed and unsigned values
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Alan Modra <amodra at gmail dot com>, Jan Beulich <JBeulich at suse dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 17 May 2016 21:59:15 -0500
- Subject: Re: [PATCH, ppc] Allow IMM8 operands to accept both signed and unsigned values
- Authentication-results: sourceware.org; auth=none
- References: <1463173058 dot 4256 dot 45 dot camel at vnet dot ibm dot com> <573AEB5B02000078000EBFB6 at prv-mh dot provo dot novell dot com> <20160518023724 dot GI24091 at bubble dot grove dot modra dot org>
On Wed, 2016-05-18 at 12:07 +0930, Alan Modra wrote:
> Peter, do you agree with the following?
>
> > * config/tc-ppc.c (ppc_insert_operand): Trim PPC_OPERAND_SIGNOPT
> > allowed negative range.
> > * testsuite/gas/ppc/power9.s: Test xxspltib of -128, not -256.
> > * testsuite/gas/ppc/power9.d: Update.
>
Hi Alan, yeah, that looks good to me. Thanks for fixing this.
Jan, I didn't really mention this in my submission, but the main
rational for this change was to allow the use of -1 as a mask of
all 1 bits for fields like these. One of our other GCC developers
thought this would simplify things in the GCC ppc port by being
able to use -1 for the mask value, rather than some unsigned mask
value that depends on the mask size.
Peter