This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2] Add port for Phoenix-RTOS in common configure files.
- From: Jeff Johnston <jjohnstn at redhat dot com>
- To: Jakub Sejdak <jakub dot sejdak at phoesys dot com>
- Cc: newlib at sourceware dot org, binutils at sourceware dot org, gdb-patches at sourceware dot org
- Date: Mon, 9 May 2016 14:20:34 -0400 (EDT)
- Subject: Re: [PATCH 1/2] Add port for Phoenix-RTOS in common configure files.
- Authentication-results: sourceware.org; auth=none
- References: <1462436036-13578-1-git-send-email-jakub dot sejdak at phoesys dot com> <716075590 dot 11881620 dot 1462569935686 dot JavaMail dot zimbra at redhat dot com> <CAFvk=0v9O7srRKTPTEzov6XXcW3_pvc47jHMyk83N=CMKnBhGA at mail dot gmail dot com> <CAFvk=0vUcGtF17Te7SroTRikM6SFhihDLEADvfQ_ZyZL-4fiVw at mail dot gmail dot com>
Hi Jakub,
One minor comment. I think you might want to follow rtems and cygwin and
use * after phoenix everywhere to allow you to add a version specifier like
rtems does.
(e.g. configure --target=sparc-rtems4.8)
If you are ok with that, I'll just add it to configure.host for you and check the
changes in.
-- Jeff J.
----- Original Message -----
> I don't get it why was the attachement stripped from previous mail.
> Here is link to FTP with this patch:
>
> http://files.phoesys.com/newlib/0001-Add-port-for-Phoenix-RTOS-in-common-configure-files.patch
>
> Thanks,
> Jakub
>
> 2016-05-09 10:46 GMT+02:00 Jakub Sejdak <jakub.sejdak@phoesys.com>:
> > Hi Jeff,
> >
> > It seems, that git-send-email replaced tabs with spaces in mail body
> > and that caused errors, because after regeneration there was no other
> > changes.
> > I attached patch once again (created from fresh newlib, just in case)
> > and added notification to proper mailing lists.
> >
> > Thanks,
> > Jakub
> >
> > 2016-05-06 23:25 GMT+02:00 Jeff Johnston <jjohnstn@redhat.com>:
> >> Jakub,
> >>
> >> Please read the top-level MAINTAINERS file for files that need to
> >> be submitted to other mailing lists. For example, configure, config.sub,
> >> configure.ac
> >>
> >> Please also update your current newlib and generate a patch that
> >> you can attach (I get all kinds of rejections trying to copy the
> >> data out of the mail). I have already committed your 2nd patch
> >> which applied fine.
> >>
> >> Thanks,
> >>
> >> -- Jeff J.
> >>
> >> ----- Original Message -----
> >>> From: Kuba Sejdak <jakub.sejdak@phoesys.com>
> >>>
> >>> ---
> >>> COPYING.NEWLIB | 26 ++++++++++++++++++++++++++
> >>> config.sub | 3 +++
> >>> configure | 6 ++++++
> >>> newlib/configure.host | 10 ++++++++++
> >>> newlib/libc/sys/configure | 3 +++
> >>> newlib/libc/sys/configure.in | 1 +
> >>> 6 files changed, 49 insertions(+)
> >>>
> >>> diff --git a/COPYING.NEWLIB b/COPYING.NEWLIB
> >>> index 24e7c73..e7e1f8a 100644
> >>> --- a/COPYING.NEWLIB
> >>> +++ b/COPYING.NEWLIB
> >>> @@ -1023,3 +1023,29 @@ CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
> >>> NEGLIGENCE OR OTHERWISE)
> >>> ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
> >>> THE
> >>> POSSIBILITY OF SUCH DAMAGE.
> >>>
> >>> +(45) Phoenix Systems - Phoenix-RTOS targets
> >>> +
> >>> +Copyright (c) 2016 Phoenix Systems
> >>> +All rights reserved.
> >>> +
> >>> +Redistribution and use in source and binary forms, with or without
> >>> +modification, are permitted provided that the following conditions
> >>> +are met:
> >>> +1. Redistributions of source code must retain the above copyright
> >>> + notice, this list of conditions and the following disclaimer.
> >>> +2. Redistributions in binary form must reproduce the above copyright
> >>> + notice, this list of conditions and the following disclaimer in the
> >>> + documentation and/or other materials provided with the distribution.
> >>> +
> >>> +THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> >>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> >>> +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> >>> PURPOSE
> >>> +ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> >>> +FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> >>> CONSEQUENTIAL
> >>> +DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> >>> +OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> >>> +HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> >>> STRICT
> >>> +LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY
> >>> WAY
> >>> +OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> >>> +SUCH DAMAGE.
> >>> +
> >>> diff --git a/config.sub b/config.sub
> >>> index da6d1b6..f7adbde 100755
> >>> --- a/config.sub
> >>> +++ b/config.sub
> >>> @@ -1531,6 +1531,9 @@ case $os in
> >>> ;;
> >>> -nacl*)
> >>> ;;
> >>> + -phoenix)
> >>> + os=-phoenix
> >>> + ;;
> >>> -none)
> >>> ;;
> >>> *)
> >>> diff --git a/configure b/configure
> >>> index 35f231e..90e3e68 100755
> >>> --- a/configure
> >>> +++ b/configure
> >>> @@ -3673,6 +3673,9 @@ case "${target}" in
> >>> *-*-netware*)
> >>> noconfigdirs="$noconfigdirs target-newlib target-libgloss"
> >>> ;;
> >>> + *-*-phoenix)
> >>> + noconfigdirs="$noconfigdirs target-libgloss"
> >>> + ;;
> >>> *-*-tpf*)
> >>> noconfigdirs="$noconfigdirs target-newlib target-libgloss"
> >>> ;;
> >>> @@ -3764,6 +3767,9 @@ case "${target}" in
> >>> arm-*-pe*)
> >>> noconfigdirs="$noconfigdirs target-libgloss"
> >>> ;;
> >>> + arm-*-phoenix*)
> >>> + noconfigdirs="$noconfigdirs target-libgloss"
> >>> + ;;
> >>> arm-*-riscix*)
> >>> noconfigdirs="$noconfigdirs ld target-libgloss"
> >>> ;;
> >>> diff --git a/newlib/configure.host b/newlib/configure.host
> >>> index bb163ec..9bc40de 100644
> >>> --- a/newlib/configure.host
> >>> +++ b/newlib/configure.host
> >>> @@ -385,6 +385,11 @@ case "${host}" in
> >>> signal_dir=
> >>> sys_dir=netware
> >>> ;;
> >>> + *-*-phoenix)
> >>> + sys_dir=phoenix
> >>> + posix_dir=posix
> >>> + unix_dir=unix
> >>> + ;;
> >>> *-*-rtems*) # generic RTEMS support
> >>> sys_dir=rtems
> >>> posix_dir=posix
> >>> @@ -578,6 +583,11 @@ case "${host}" in
> >>> newlib_cflags="${newlib_cflags} -DHAVE_OPENDIR -DHAVE_RENAME
> >>> -DSIGNAL_PROVIDED -D_COMPILING_NEWLIB -DHAVE_BLKSIZE -DHAVE_FCNTL
> >>> -DMALLOC_PROVIDED"
> >>> syscall_dir=syscalls
> >>> ;;
> >>> + *-*-phoenix)
> >>> + newlib_cflags="${newlib_cflags} -DMISSING_SYSCALL_NAMES
> >>> -D_COMPILING_NEWLIB
> >>> -DHAVE_BLKSIZE -DHAVE_NANOSLEEP"
> >>> + default_newlib_io_long_long="yes"
> >>> + syscall_dir=
> >>> + ;;
> >>> # RTEMS supplies its own versions of some routines:
> >>> # malloc() (reentrant version)
> >>> # exit() RTEMS has a "global" reent to flush
> >>> diff --git a/newlib/libc/sys/configure b/newlib/libc/sys/configure
> >>> index d64b0dd..55c6e13 100755
> >>> --- a/newlib/libc/sys/configure
> >>> +++ b/newlib/libc/sys/configure
> >>> @@ -797,6 +797,7 @@ m88kbug
> >>> mmixware
> >>> netware
> >>> or1k
> >>> +phoenix
> >>> rdos
> >>> rtems
> >>> sh
> >>> @@ -11828,6 +11829,8 @@ subdirs="$subdirs a29khif"
> >>> ;;
> >>> or1k) subdirs="$subdirs or1k"
> >>> ;;
> >>> + phoenix) subdirs="$subdirs phoenix"
> >>> + ;;
> >>> rdos) subdirs="$subdirs rdos"
> >>> ;;
> >>> rtems) subdirs="$subdirs rtems"
> >>> diff --git a/newlib/libc/sys/configure.in b/newlib/libc/sys/configure.in
> >>> index b50a6d3..bc6cb88 100644
> >>> --- a/newlib/libc/sys/configure.in
> >>> +++ b/newlib/libc/sys/configure.in
> >>> @@ -34,6 +34,7 @@ if test -n "${sys_dir}"; then
> >>> mmixware) AC_CONFIG_SUBDIRS(mmixware) ;;
> >>> netware) AC_CONFIG_SUBDIRS(netware) ;;
> >>> or1k) AC_CONFIG_SUBDIRS(or1k) ;;
> >>> + phoenix) AC_CONFIG_SUBDIRS(phoenix) ;;
> >>> rdos) AC_CONFIG_SUBDIRS(rdos) ;;
> >>> rtems) AC_CONFIG_SUBDIRS(rtems) ;;
> >>> sh) AC_CONFIG_SUBDIRS(sh) ;;
> >>> --
> >>> 2.7.4
> >>>
> >>>
>