This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [committed, PATCH] Always create dynsym section with dynamic sections
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Faraz Shahbazker <faraz dot shahbazker at imgtec dot com>, Binutils <binutils at sourceware dot org>
- Date: Tue, 26 Apr 2016 11:38:19 +0930
- Subject: Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Authentication-results: sourceware.org; auth=none
- References: <571ADE8F dot 9000000 at imgtec dot com> <CAMe9rOqs5bCUX7O7k3Wp7mLmSfS5mCdDRT_g8XbhQ3LDJ1wQgg at mail dot gmail dot com> <571B93C6 dot 5030007 at imgtec dot com> <CAMe9rOrTtaCdebLXVWWFoMcSBiF34rRmjRBY9kzo7tHwuU9r2Q at mail dot gmail dot com> <571BCC3A dot 6090700 at imgtec dot com> <CAMe9rOpuLNQT-m5ym56FOeCDUJWcBB2fkB-okvu96MX7pn83nA at mail dot gmail dot com> <571D7E59 dot 4040802 at imgtec dot com> <CAMe9rOoau_6NMbaiScJJnnWY-vYNpX4KPvakS3-h0QGzp98u9Q at mail dot gmail dot com> <20160425134106 dot GI27353 at bubble dot grove dot modra dot org> <CAMe9rOrLVN-Yq1py3XyfCduwMQnSNquRN=kDfAhKRHk9gTxX9Q at mail dot gmail dot com>
On Mon, Apr 25, 2016 at 09:03:06AM -0700, H.J. Lu wrote:
> On Mon, Apr 25, 2016 at 6:41 AM, Alan Modra <amodra@gmail.com> wrote:
> > On Mon, Apr 25, 2016 at 05:47:15AM -0700, H.J. Lu wrote:
> >> On Sun, Apr 24, 2016 at 7:18 PM, Faraz Shahbazker
> >> <faraz.shahbazker@imgtec.com> wrote:
> >> > On 04/23/16 18:42, H.J. Lu wrote:
> >> >> Here is a patch. Does it work for you?
> >> > Yes, this works.
> >> >
> >>
> >> Any other comments, feedbacks for my patch?
> >
> > I think you'd better look at all places that test dynsymcount. For
> > instance, bfd_elf_size_dynsym_hash_dynstr.
>
> I checked. They look OK.
>
> > This should really have been done when you committed
> > https://sourceware.org/ml/binutils/2016-02/msg00326.html and that
> > patch should have explained why the change was made. "We should
> > always create the dynsym section, even if it is empty, with dynamic
> > sections" doesn't explain anything about why the change was made. In
> > fact, the explanation for the patch was no better than "We should do
> > what this patch does".
>
> The issue is some dynamic tags (sections) are mandatory in .dynamic
> section even if they are empty. MIPS backend use dynsymcount, which
> is intended for the mandatory DT_SYMTAB (.dynsym section), to build
> static executable, which doesn't have dynamic section. Here is the
> updated patch. Is it OK for master?
The dynsymcount != 0 tests in bfd_elf_size_dynsym_hash_dynstr will
never trigger with your patch. Please remove them. OK with that
change.
--
Alan Modra
Australia Development Lab, IBM
- References:
- Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Re: [committed, PATCH] Always create dynsym section with dynamic sections
- Re: [committed, PATCH] Always create dynsym section with dynamic sections