This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, ARM 7/7] Add support for ARMv8-M Mainline with DSP extension


On Wednesday 30 March 2016 16:26:56 Nick Clifton wrote:
> Hi Thomas,
> 
> > *** bfd/ChangeLog ***
> > 2015-11-10  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> > 
> >          (elf32_arm_merge_eabi_attributes): Add merging logic for
> >          Tag_DSP_extension.
> > 
> > *** binutils/ChangeLog ***
> > 2015-11-10  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> > 
> >          * readelf.c (display_arm_attribute): Add output for
> >          Tag_DSP_extension.
> >          (arm_attr_public_tags): Define DSP_extension attribute.
> > 
> > *** gas/ChangeLog ***
> > 2016-03-07  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> > 
> >          * config/tc-arm.c (arm_ext_dsp): New feature for Thumb DSP
> >          instructions.
> >          (arm_extensions): Add dsp extension for ARMv8-M Mainline.
> >          (aeabi_set_public_attributes): Memorize the feature bits of the
> >          architecture selected for Tag_CPU_arch.  Use it to set
> >          Tag_DSP_extension to 1 for ARMv8-M Mainline with DSP extension.
> >          (arm_convert_symbolic_attribute): Define Tag_DSP_extension.
> >          * testsuite/gas/arm/arch7em-bad.d: Rename to ...
> >          * testsuite/gas/arm/arch7em-bad-1.d: This.
> >          * testsuite/gas/arm/arch7em-bad-2.d: New file.
> >          * testsuite/gas/arm/arch7em-bad-3.d: Likewise.
> >          * testsuite/gas/arm/archv8m-main-dsp-1.d: Likewise.
> >          * testsuite/gas/arm/archv8m-main-dsp-2.d: Likewise.
> >          * testsuite/gas/arm/archv8m-main-dsp-3.d: Likewise.
> >          * testsuite/gas/arm/archv8m-main-dsp-4.d: Likewise.
> >          * testsuite/gas/arm/archv8m-main-dsp-5.d: Likewise.
> >          * testsuite/gas/arm/attr-march-armv8m.main.dsp.d: Likewise.
> > 
> > *** include/elf/ChangeLog ***
> > 2015-11-10  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> > 
> >          * arm.h (Tag_DSP_extension): Define.
> > 
> > *** ld/ChangeLog ***
> > 2016-03-07  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> > 
> >          * testsuite/ld-arm/arm-elf.exp (EABI attribute merging 10 (DSP)):
> >          New
> >          test.
> >          * testsuite/ld-arm/attr-merge-10b-dsp.s: New file.
> >          * testsuite/ld-arm/attr-merge-10-dsp.attr: Likewise.
> 
> Approved - please apply - but ...
> 
> Please could you also add an entry to gas/NEWS mentioning the support for
> the new instructions.

I'm a bit confused at the current content of gas/NEWS. It mentions twice 
"Changes in 2.26". Is the top one supposed to be 2.27? I'm not sure about it 
because it has been created on November 13th of last year.

Best regards,

Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]