This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH 2/4] Add support for .extInstruction pseudo-op.
- From: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- To: Nick Clifton <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: Francois Bedard <Francois dot Bedard at synopsys dot com>
- Date: Tue, 12 Apr 2016 08:31:19 +0000
- Subject: RE: [PATCH 2/4] Add support for .extInstruction pseudo-op.
- Authentication-results: sourceware.org; auth=none
- References: <1460368239-7577-1-git-send-email-claziss at synopsys dot com> <1460368239-7577-2-git-send-email-claziss at synopsys dot com> <570BAB26 dot 2040901 at redhat dot com>
Committed. Thank you Nick for your review,
Claudiu
> -----Original Message-----
> From: Nick Clifton [mailto:nickc@redhat.com]
> Sent: Monday, April 11, 2016 3:48 PM
> To: Claudiu Zissulescu; binutils@sourceware.org
> Subject: Re: [PATCH 2/4] Add support for .extInstruction pseudo-op.
>
> Hi Claudiu,
>
> Approved - please apply, but ...
>
>
> > +static void tokenize_extinsn (extInstruction_t *einsn)
>
> Please place the function name at the start of its own line.
>
> > +static void arc_extinsn (int ignore ATTRIBUTE_UNUSED)
>
> Likewise.
>
> Cheers
> Nick