Re: Can the automatic daily update commits be stopped, take 2

[Mike Frysinger <vapier at gentoo dot org>]

On 28 Jan 2016 16:25, H.J. Lu wrote:
> On Thu, Jan 28, 2016 at 3:15 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On 28 Jan 2016 15:01, H.J. Lu wrote:
> >> On Thu, Jan 28, 2016 at 2:56 PM, David Howells <dhowells@redhat.com> wrote:
> >> > David Howells <dhowells@redhat.com> wrote:
> >> >> Can the automatic "daily update" and "Automatic date update in version.in"
> >> >> commits be stopped?  Or at least only performed if the last commit was not
> >> >> itself such a commit?
> >> >
> >> > I note that these are still being produced.  Is it possible to stop them as
> >> > they make a mess of the git history?
> >> >
> >> > I think Andreas Schwab suggested that it might be necessary as you can't
> >> > directly compare two git hashes without a repo handy to give them context -
> >> > but how often is that actually a problem?  If you are comparing two points on
> >> > the same branch, you can consult the ChangeLog files and if they're produced
> >> > separate branches, then comparing the dates is potentially meaningless anyway.
> >> >
> >> > Further, not having an incrementing version doesn't necessarily mean that you
> >> > can't name published tarballs for the date on which they're produced.
> >>
> >> I don't mind stopping updating bfd/version.h as long as "ld --version"
> >> displays different versions from linkers of different dates.
> >
> > s/dates/source trees (e.g. diff git sha1)/
> 
> It is hard to tell which one is newer without using git source.

that isn't what you said.  your statement says that, even if you use the
same source, but built on different date, you get diff output.  i'm saying
that, like David, the daily bumps shouldn't happen unless an actual change
landed.  so if nothing was committed between Jan 10th and Jan 20th, my
builds from Jan 15th should be the same as Jan 10th.

if your only requirement is that `ld --version` accurately reflect the git
version, and include a timestamp for that git commit so you can easily do a
compare w/out sources, then that doesn't even need a daily bump to happen.

i would point out that even today your requirements aren't met -- the bump
is a daily one which means the ld built at 00:01 can be radically different
from the one built at 23:59, yet they still report the same --version.

in the CVS world, doing a daily bump was needed because the VCS itself had
no way of providing a fingerprint.  git has no such limitation, so doing a
bump at all is anachronistic.
$ git log -1 --format='format:%ci %H' HEAD
2016-01-24 19:24:18 -0500 1fe8799f24883105c476677803dfb5acc0b2ca63
-mike

Attachment: signature.asc
Description: Digital signature