This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[RFC PATCH 06/11] MIPS/BFD: Propagate the return status in attribute merging
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <binutils at sourceware dot org>
- Cc: Matthew Fortune <Matthew dot Fortune at imgtec dot com>, Daniel Sanders <Daniel dot Sanders at imgtec dot com>
- Date: Fri, 20 Nov 2015 14:50:06 +0000
- Subject: [RFC PATCH 06/11] MIPS/BFD: Propagate the return status in attribute merging
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 00 dot 1511200755190 dot 6915 at tp dot orcam dot me dot uk>
Fix the issue of any failure from `_bfd_elf_merge_object_attributes' not
being propagated by `mips_elf_merge_obj_attributes'.
bfd/
* elfxx-mips.c (mips_elf_merge_obj_attributes): Propagate the
return status from `_bfd_elf_merge_object_attributes'.
---
binutils-mips-bfd-merge-attrs-err.diff
Index: binutils/bfd/elfxx-mips.c
===================================================================
--- binutils.orig/bfd/elfxx-mips.c 2015-11-17 13:08:53.766355754 +0000
+++ binutils/bfd/elfxx-mips.c 2015-11-17 13:08:57.091576699 +0000
@@ -15206,9 +15206,7 @@ mips_elf_merge_obj_attributes (bfd *ibfd
}
/* Merge Tag_compatibility attributes and any common GNU ones. */
- _bfd_elf_merge_object_attributes (ibfd, obfd);
-
- return TRUE;
+ return _bfd_elf_merge_object_attributes (ibfd, obfd);
}
/* Merge backend specific data from an object file to the output