This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR gold/19184: Bad assumption on GOT entry size
- From: Cary Coutant <ccoutant at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Thu, 29 Oct 2015 09:13:54 -0700
- Subject: Re: [PATCH] PR gold/19184: Bad assumption on GOT entry size
- Authentication-results: sourceware.org; auth=none
- References: <20151029160151 dot GA391 at gmail dot com>
> The GOT entry size is target-dependent. This patch adds a got_entry_size
> function to Sized_target class so that a target can provide a value
> different from default.
>
> OK for master?
>
> H.J.
> ---
> PR gold/19184
> * incremental.cc (Got_plt_view_info): Add got_entry_size.
> (Local_got_offset_visitor::visit): Replace got_entry_size_
> with info_.got_entry_size.
> (Local_got_offset_visitor::got_entry_size_): Removed.
> (Global_got_offset_visitor::visit): Replace got_entry_size_
> with info_.got_entry_size.
> (Global_got_offset_visitor::got_entry_size_): Removed.
> (Output_section_incremental_inputs::write_got_plt): Initialize
> view_info.got_entry_size.
> * target.h (Sized_target::got_entry_size): New virtual function.
> * x86_64.cc (Target_x86_64::got_entry_size): New function.
> + // Return the size of each GOT entry.
> + unsigned int
> + got_entry_size() const { return 8; };
Please put the function body on the next line.
This is OK with that change. Thanks!
-cary