This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] config/tc-avr.c (md_section_align): Append UL for -1 to avoid the latest gcc's warning
- From: gang dot chen dot 5i5j at gmail dot com
- To: binutils at sourceware dot org, gdb-patches at sourceware dot org
- Cc: xili_gchen_5257 at hotmail dot com, Chen Gang <gang dot chen dot 5i5j at gmail dot com>
- Date: Sat, 5 Sep 2015 16:05:16 +0800
- Subject: [PATCH] config/tc-avr.c (md_section_align): Append UL for -1 to avoid the latest gcc's warning
- 0/x-total-score: 0:
- 1/x-total-score: 0:
- Authentication-results: sourceware.org; auth=none
- Hmm_attache_num: 0000
- Hmm_source_ip: 10.64.8.32:64055.816105773
- Hmm_source_type: SMTP
From: Chen Gang <gang.chen.5i5j@gmail.com>
The related warning is:
gcc -DHAVE_CONFIG_H -I. -I../../binutils-gdb/gas -I. -I../../binutils-gdb/gas -I../bfd -I../../binutils-gdb/gas/config -I../../binutils-gdb/gas/../include -I../../binutils-gdb/gas/.. -I../../binutils-gdb/gas/../bfd -DLOCALEDIR="\"/upstream/release-avr32/share/locale\"" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -I../../binutils-gdb/gas/../zlib -g -O2 -MT tc-avr.o -MD -MP -MF .deps/tc-avr.Tpo -c -o tc-avr.o `test -f 'config/tc-avr.c' || echo '../../binutils-gdb/gas/'`config/tc-avr.c
../../binutils-gdb/gas/config/tc-avr.c: In function âmd_section_alignâ:
../../binutils-gdb/gas/config/tc-avr.c:1233:43: error: left shift of negative value [-Werror=shift-negative-value]
return ((addr + (1 << align) - 1) & (-1 << align));
^
2015-09-05 Chen Gang <gang.chen.5i5j@gmail.com>
* config/tc-avr.c (md_section_align): Append UL for -1 to avoid
the latest gcc's warning.
---
gas/ChangeLog | 5 +++++
gas/config/tc-avr.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 2dc9742..c0fb096 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2015-09-05 Chen Gang <gang.chen.5i5j@gmail.com>
+
+ * config/tc-avr.c (md_section_align): Append UL for -1 to avoid
+ the latest gcc's warning.
+
2015-08-27 Alan Modra <amodra@gmail.com>
PR gas/18581
diff --git a/gas/config/tc-avr.c b/gas/config/tc-avr.c
index c69a91c..09eea48 100644
--- a/gas/config/tc-avr.c
+++ b/gas/config/tc-avr.c
@@ -1230,7 +1230,7 @@ valueT
md_section_align (asection *seg, valueT addr)
{
int align = bfd_get_section_alignment (stdoutput, seg);
- return ((addr + (1 << align) - 1) & (-1 << align));
+ return ((addr + (1 << align) - 1) & (-1UL << align));
}
/* If you define this macro, it should return the offset between the
--
1.9.3