This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATH] AMD MWAITX enablement
- From: "Pawar, Amit" <Amit dot Pawar at amd dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Jan Beulich <JBeulich at suse dot com>
- Date: Fri, 26 Jun 2015 17:06:00 +0000
- Subject: RE: [PATH] AMD MWAITX enablement
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; gmail.com; dkim=none (message not signed) header.d=none;
- References: <0428E25D138CAA4D819A6FED9429E51AF4A29C at SCYBEXDAG02 dot amd dot com> <556D83DE02000078000800CE at mail dot emea dot novell dot com> <0428E25D138CAA4D819A6FED9429E51AF4A96C at SCYBEXDAG02 dot amd dot com> <55755AD50200007800081CE1 at mail dot emea dot novell dot com> <0428E25D138CAA4D819A6FED9429E51AF4CB28 at SCYBEXDAG02 dot amd dot com> <CAMe9rOocBnj6cEvcPLOg1cqm69bQgv1hC+9z-PP28TW3YCJRVA at mail dot gmail dot com> <0428E25D138CAA4D819A6FED9429E51AF4CBC5 at SCYBEXDAG02 dot amd dot com> <CAMe9rOpA=cZLNeAE0-kag8oU8hOJLubArHFZFEbmFnT7VeYrzQ at mail dot gmail dot com> <0428E25D138CAA4D819A6FED9429E51AF4CC18 at SCYBEXDAG02 dot amd dot com> <CAMe9rOogt0E+KrGwHcFWeyeTO-urVbT3K-NsOQaPDtZtU6heQg at mail dot gmail dot com> <0428E25D138CAA4D819A6FED9429E51AF4CC42 at SCYBEXDAG02 dot amd dot com> <CAMe9rOp0ELpkHcapKMEid7Egr0+N70L9TscitPXNg0od3OffJw at mail dot gmail dot com> <0428E25D138CAA4D819A6FED9429E51AF4CC6E at SCYBEXDAG02 dot amd dot com> <CAMe9rOq-Wz_bEEznq_Fq--LCpQ89PRqU8y78mRhnW6NnH_ob=w at mail dot gmail dot com> <0428E25D138CAA4D819A6FED9429E51AF4CCA0 at SCYBEXDAG02 dot amd dot com> <CAMe9rOrTkha5syNS6npijtvSpuTKke7fe+=P0gPJfjmqfUUuoQ at mail dot gmail dot com>
Can you please apply it to the trunk ? I do have access to it. Thank you.
-----Original Message-----
From: H.J. Lu [mailto:hjl.tools@gmail.com]
Sent: Friday, June 26, 2015 10:14 PM
To: Pawar, Amit
Cc: binutils@sourceware.org; Jan Beulich
Subject: Re: [PATH] AMD MWAITX enablement
On Fri, Jun 26, 2015 at 9:39 AM, Pawar, Amit <Amit.Pawar@amd.com> wrote:
> PFA MWAITX updated patch. Is it OK?
>
+ for (x = 0; x < 2; x++)
+ if (register_number (i.op[x].regs) != x)
+ goto bad_register_operand;
Please fix indentation.
+
+ /* Check for third operand for mwaitx/monitorx insn*/
+ if (register_number (i.op[2].regs) !=
+ ( 2 + (i.tm.extension_opcode == 0xfb)))
^^ Remove extra space before 2.
Please use "x" instead of "2".
+ {
+bad_register_operand:
+ as_bad (_("can't use register '%s%s' as operand %d in '%s'."),
+ register_prefix, i.op[x].regs->reg_name, x+1,
+ i.tm.name);
+ }
OK with those changes.
Thanks.
--
H.J.