This is the mail archive of the
mailing list for the binutils project.
Re: [GAS][AARCH64]use subseg_text_p to check whether current segment is thought to hold text.
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Renlin Li <renlin dot li at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Nicholas Clifton <nickc at redhat dot com>
- Date: Tue, 7 Apr 2015 17:23:05 +0100
- Subject: Re: [GAS][AARCH64]use subseg_text_p to check whether current segment is thought to hold text.
- Authentication-results: sourceware.org; auth=none
- References: <5523E79F dot 5030205 at arm dot com>
On 7 April 2015 at 15:20, Renlin Li <firstname.lastname@example.org> wrote:
> Hi all,
> Direct compare with text_section is not a good way to check whether the
> section is thought to hold text or not. subseg_text_p is used instead to
> cover more cases. The section's flags are checked within subseg_text_p
> Binutils regression test runs Okay. aarch64-none-linux-gnu is cross-built
> and checked without any new issues.
> Okay to commit?
> 2015-04-07 Renlin Li <email@example.com>
> * config/tc-aarch64.c (mapping_state): Use subseg_text_p.
> (s_aarch64_inst): Likewise.
> (md_assemble): Likewise.
+ if (TRANSITION (MAP_UNDEFINED, MAP_DATA) && !subseg_text_p (now_seg))
+ /* Emit MAP_DATA within executable section in order. Otherwise, it will be
Double space after period, likewise the following three comments. Otherwise OK