Re: [AArch64/PATCH 1/2] Rename xgene-1 to xgene1.

[Marcus Shawcroft <marcus dot shawcroft at gmail dot com>]

On 17 November 2014 22:33, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> This change has been lingering unmerged for a while and the xgene-1
> name has never been widely used in other tools. All other patches
> (e.g. gcc) and common usage in the wild has always been through the
> 'xgene1' identifier.

Hi Philipp,  binutils-2.25 shipped with support for the name xgene-1.
Now that we have a production toolchain released that recognizes that
name I think it would be inappropriate to remove support for the name.
Doing so risks breaking infrastructure/build scripts that folks have
put together that assume support for xgene-1.  I suggest that we
retain the existing name xgene-1 for 'compatibility' and add a new
core xgene1 with the preferred name.  I think it reasonable that the
texi documentation indicate that the xgene1 is preferred name and that
xgene-1 is deprecated.

Cheers
/Marcus


> ---
>  gas/ChangeLog           | 5 +++++
>  gas/config/tc-aarch64.c | 2 +-
>  gas/doc/c-aarch64.texi  | 2 +-
>  3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/gas/ChangeLog b/gas/ChangeLog
> index 3b1d034..943feb2 100644
> --- a/gas/ChangeLog
> +++ b/gas/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-01-07  Philipp Tomsich  <philipp.tomsich@theobroma-systems.com>
> +
> +       * config/tc-aarch64.c (aarch64_cpus): Rename "xgene-1" to "xgene1" to
> +       sync up with other tools (as distributed in our BSP) and collateral.
> +
>  2014-11-17  Ilya Tocar  <ilya.tocar@intel.com>
>
>         * config/tc-i386.c (cpu_arch): Add .avx512vbmi.
> diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> index 08fc180..b6f8ed5 100644
> --- a/gas/config/tc-aarch64.c
> +++ b/gas/config/tc-aarch64.c
> @@ -7253,7 +7253,7 @@ static const struct aarch64_cpu_option_table aarch64_cpus[] = {
>    {"cortex-a57", AARCH64_FEATURE(AARCH64_ARCH_V8,
>                                  AARCH64_FEATURE_CRC), "Cortex-A57"},
>    {"thunderx", AARCH64_ARCH_V8, "Cavium ThunderX"},
> -  {"xgene-1", AARCH64_ARCH_V8, "APM X-Gene 1"},
> +  {"xgene1", AARCH64_ARCH_V8, "APM X-Gene 1"},
>    {"generic", AARCH64_ARCH_V8, NULL},
>
>    {NULL, AARCH64_ARCH_NONE, NULL}
> diff --git a/gas/doc/c-aarch64.texi b/gas/doc/c-aarch64.texi
> index f3d4e41..8e22b21 100644
> --- a/gas/doc/c-aarch64.texi
> +++ b/gas/doc/c-aarch64.texi
> @@ -59,7 +59,7 @@ on the target processor.  The following processor names are recognized:
>  @code{cortex-a57},
>  @code{thunderx},
>  and
> -@code{xgene-1}.
> +@code{xgene1}.
>  The special name @code{all} may be used to allow the assembler to accept
>  instructions valid for any supported processor, including all optional
>  extensions.
> --
> 1.9.1
>