This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, i386] Add option to control rounding bits of SAE-only instructions.

From: Ilya Tocar <tocarip dot intel at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Tue, 16 Sep 2014 15:44:52 +0400
Subject: Re: [PATCH, i386] Add option to control rounding bits of SAE-only instructions.
Authentication-results: sourceware.org; auth=none
References: <20140915133351 dot GA1778 at msticlxl7 dot ims dot intel dot com> <CAMe9rOqPgGDOyPUdKbHL71M7uJCqeOMEJn=Ah=LGc9TVCYez7Q at mail dot gmail dot com>

On 15 Sep 09:06, H.J. Lu wrote:
> On Mon, Sep 15, 2014 at 6:33 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> > Hi,
> >
> > For SAE-only evex instructions rounding/LL bits can have any value.
> > Currently we encode them with 00 bits. Attached patch add -mevexrndig
> > option, which controls this behavior.
> > Ok for trunk?
> 
> A couple comments:
> 
> 1. Please use -mevexrcig.
> 2. Please remove force_rounding_bits and just do
> 
> else if (evexrcig)
>   i.vex.bytes[3] |= 0x10 | (evexrcig << 5);
> 
> and make sure there is one space between "0x10 |" and  "(evexrcig << 5);".
> 3. Sync against trunk since I renamed OPTION_omit_lock_prefix
> to OPTION_OMIT_LOCK_PREFIX.

Done.

Attachment: patch.tar.bz2
Description: BZip2 compressed data

Follow-Ups:
- Re: [PATCH, i386] Add option to control rounding bits of SAE-only instructions.
  - From: H.J. Lu

References:
- [PATCH, i386] Add option to control rounding bits of SAE-only instructions.
  - From: Ilya Tocar
- Re: [PATCH, i386] Add option to control rounding bits of SAE-only instructions.
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]