This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] MIPS/gas: LQC2, LDC3 and SQC2 macro !microMIPS assertions
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: <binutils at sourceware dot org>
- Date: Thu, 21 Aug 2014 14:05:32 +0100
- Subject: [PATCH] MIPS/gas: LQC2, LDC3 and SQC2 macro !microMIPS assertions
- Authentication-results: sourceware.org; auth=none
Hi,
This adds missing !microMIPS assertions for the LQC2, LDC3 and SQC2
macros whose underlying instructions have no microMIPS encoding.
No regressions across mips-elf, mips-sde-elf, mips-sgi-irix5,
mips-sgi-irix6, mips-freebsd, mips-linux, mips-vxworks, mips64-freebsd,
mips64-linux, mips64el-freebsd, mips64el-linux, mipsel-elf,
mipsel-freebsd, mipsel-linux, mipsel-vxworks, mipsisa32-elf,
mipsisa32-linux, mipsisa32el-elf, mipsisa32el-linux, mipsisa64-elf,
mipsisa64-linux, mipsisa64el-elf, mipsisa64el-linux. OK to apply?
2014-08-21 Maciej W. Rozycki <macro@codesourcery.com>
gas/
* config/tc-mips.c (macro) <M_LQC2_AB>: Assert that !microMIPS.
<M_LDC3_AB, M_SQC2_AB>: Likewise.
Maciej
binutils-gas-umips-assert.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2014-04-04 16:00:19.748876849 +0100
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2014-04-04 16:00:39.758186405 +0100
@@ -10773,12 +10773,14 @@ macro (struct mips_cl_insn *ip, char *st
coproc = 1;
goto ld_st;
case M_LQC2_AB:
+ gas_assert (!mips_opts.micromips);
s = "lqc2";
fmt = "+7,o(b)";
/* Itbl support may require additional care here. */
coproc = 1;
goto ld_st;
case M_LDC3_AB:
+ gas_assert (!mips_opts.micromips);
s = "ldc3";
fmt = "E,o(b)";
/* Itbl support may require additional care here. */
@@ -10937,6 +10939,7 @@ macro (struct mips_cl_insn *ip, char *st
coproc = 1;
goto ld_st;
case M_SQC2_AB:
+ gas_assert (!mips_opts.micromips);
s = "sqc2";
fmt = "+7,o(b)";
/* Itbl support may require additional care here. */