This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] fix mingw32 --enable-targets=all --enable-64-bit-bfd failure in or1k-desc.h


On Tue, May 20, 2014 at 10:50:12AM +0200, Pierre Muller wrote:
> > On Sat, May 17, 2014 at 11:09:06PM +0200, Pierre Muller wrote:
> > > 2014-05-17  Pierre Muller  <muller@sourceware.org>
> > >
> > > 	* or1k-desc.h (enum spr_field_masks): Remove compilation warning
> > > 	on 32-bit systems.
> > >
> > > diff --git a/opcodes/or1k-desc.h b/opcodes/or1k-desc.h
> > 
> > No, sorry, this file is generated.  If this patch is committed, it
> > will be undone next time the file is regenerated.  I suspect you'll
> > need to poke at cgen itself to fix this problem.
> 
>   Sorry, but this goes way beyond my skills...
> I looked a little bit in cpu/or1* files
> and in the opcodes/cgen* files, and this seems to
> be based on guile, which is a language I know nothing about ...

I took a look, and it seems to me there is no need for enum
spr_field_masks..  OK, Christian?

cpu/
	* or1kcommon.cpu (spr-field-masks): Delete.
opcodes/
	* or1k-desc.h: Regenerate.

diff --git a/cpu/or1kcommon.cpu b/cpu/or1kcommon.cpu
index 1119f98..b23efbe 100644
--- a/cpu/or1kcommon.cpu
+++ b/cpu/or1kcommon.cpu
@@ -301,22 +301,6 @@
         )
   )
 
-(define-normal-enum
-  spr-field-masks
-  "SPR field masks"
-  ()
-  SPR-FIELD-MASK-
-  (.map (.pmacro (args)
-                 (.apply (.pmacro (group index field msb lsb comment)
-                                  (.splice (.str group "-" index "-" field) (.sll (.inv (.sll (.inv 0) (.add (.sub msb lsb) 1))) lsb))
-                                  )
-                         args
-                         )
-                 )
-        (spr-field-info)
-        )
-  )
-
 (define-pmacro (define-h-spr-field spr-group spr-index spr-field spr-field-msb spr-field-lsb spr-field-comment)
   (.let ((spr-field-name (.sym "h-" (.downcase spr-group) "-" (.downcase spr-index) "-" (.downcase spr-field)))
          )

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]