This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: as error output not -j64 safe
- From: Alan Modra <amodra at gmail dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: Andrew Pinski <pinskia at gmail dot com>, binutils <binutils at sourceware dot org>
- Date: Fri, 16 May 2014 18:21:20 +0930
- Subject: Re: as error output not -j64 safe
- Authentication-results: sourceware.org; auth=none
- References: <819223B1-7BDF-46C0-80CE-EF49878BA3C8 at comcast dot net> <CA+=Sn1m3VExcetsFHU62+aKDbQYyZTJjYjX1UE0KfovhwyhyXw at mail dot gmail dot com> <36FD025D-0FE1-4248-A154-E28F998F5B73 at comcast dot net>
On Thu, May 15, 2014 at 04:13:24PM -0700, Mike Stump wrote:
> --- a/binutils/gas/messages.c
> +++ b/binutils/gas/messages.c
> @@ -219,13 +219,12 @@ as_bad_internal (char *file, unsigned int line, char *buffer)
> if (file)
> {
> if (line != 0)
> - fprintf (stderr, "%s:%u: ", file, line);
> + fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Error:"), buffer);
> else
> - fprintf (stderr, "%s: ", file);
> + fprintf (stderr, "%s: %s %s\n", file, _("Error:"), buffer);
> }
> - fprintf (stderr, _("Error: "));
> - fputs (buffer, stderr);
> - (void) putc ('\n', stderr);
> + else
> + fprintf (stderr, "%s %s\n", _("Error:"), buffer);
> #ifndef NO_LISTING
> listing_error (buffer);
> #endif
OK. Please also fix as_warn_internal similarly to the above. There
are quite a few more cases of the same problem in this file, if you
care to look..
--
Alan Modra
Australia Development Lab, IBM