This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][MIPS] file_mips_xxx consolidation


Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
> Do you want the change to use a new FPR_SIZE macro to follow on
> from this?

Yeah, I think it makes sense to do that separately from this patch.

Just one minor nit:

> @@ -18027,8 +18024,8 @@ mips_parse_cpu (const char *option, const char *cpu_string)
>        if (ABI_NEEDS_64BIT_REGS (mips_abi))
>  	return mips_cpu_info_from_isa (ISA_MIPS3);
>  
> -      if (file_mips_gp32 >= 0)
> -	return mips_cpu_info_from_isa (file_mips_gp32 ? ISA_MIPS1 : ISA_MIPS3);
> +      if (file_mips_opts.gp32 >= 0)
> +	return mips_cpu_info_from_isa (file_mips_opts.gp32 ? ISA_MIPS1 : ISA_MIPS3);
>  
>        return mips_cpu_info_from_isa (MIPS_DEFAULT_64BIT
>  				     ? ISA_MIPS3

This line is now longer than 80 chars so please break before "?" or ":".

OK with that change, thanks.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]