This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: gold regression vs BFD ld: __ehdr_start

From: Cary Coutant <ccoutant at google dot com>
To: Roland McGrath <mcgrathr at google dot com>
Cc: Ian Lance Taylor <iant at google dot com>, Binutils <binutils at sourceware dot org>
Date: Tue, 1 Apr 2014 16:02:43 -0700
Subject: Re: gold regression vs BFD ld: __ehdr_start
Authentication-results: sourceware.org; auth=none
References: <20140330011513 dot D6435744AE at topped-with-meat dot com> <CAKOQZ8x2Aj3reAZKyEAAKKjcFFTu7KZY01WwXCHiOD0WLQC=_g at mail dot gmail dot com> <CAHACq4qsJMXQAXnjEGp3xQjfyztVkhXccEeLYvz7Qn=piJD40Q at mail dot gmail dot com> <CAB=4xhrE7=X1EwOFmOxmw4D8akKvYBDfruTknM6Lbce=4JGjuA at mail dot gmail dot com> <CAHACq4qz==mw2zqkez=JeZqj0kPJPwiC2RVO--=qFb87r84CFw at mail dot gmail dot com> <CAB=4xhrH5ap=uPuMPDoPhJ3gNZ-P0VFcKXLpbHbhGAakta=FDg at mail dot gmail dot com> <CAHACq4oOLFxnTpF4gGvjFAYgQoHyok=_mEiBpijSkAQ9PPV1fg at mail dot gmail dot com> <CAB=4xho=wbxV4AQD2W5ph92J3892k2y4rCX9yr0_Am7kd21TOg at mail dot gmail dot com> <CAHACq4rK8b6ccn9mqWzbDwXiUEkgxmLmY0MNfn8-uNe64PwP3g at mail dot gmail dot com> <CAHACq4qMuqoo+EWtxdDkWX_HK1wQ5_LSt2eqraWgz3kScXk6YQ at mail dot gmail dot com>

Here's an updated patch that handles the weak reference properly and
handles __ehdr_start correctly (at least) when a SECTIONS clause is
present.

-cary


2014-04-01  Cary Coutant  <ccoutant@google.com>

        * gold/defstd.cc (in_segment): Define __ehdr_start here...
        * gold/layout.cc (Layout::finalize): ...Instead of here.  Set the
        output segment when known.
        * gold/resolve.cc (Symbol::override_base_with_special): Remember
        the original binding.
        * gold/symtab.cc (Symbol::set_output_segment): New function.
        (Symbol::set_undefined): New function.
        * gold/symtab.h (Symbol::is_weak_undefined): Check original undef
        binding.
        (Symbol::is_strong_undefined): New function.
        (Symbol::set_output_segment): New function.
        (Symbol::set_undefined): New function.
        * gold/target-reloc.h (is_strong_undefined): Remove.
        (issue_undefined_symbol_error): Call Symbol::is_weak_undefined.
        Check for hidden undefs.
        (relocate_section): Call Symbol::is_strong_undefined.

Attachment: ehdr-start-patch-3.txt
Description: Text document

Follow-Ups:
- Re: gold regression vs BFD ld: __ehdr_start
  - From: Roland McGrath

References:
- Re: gold regression vs BFD ld: __ehdr_start
  - From: Roland McGrath
- Re: gold regression vs BFD ld: __ehdr_start
  - From: Cary Coutant
- Re: gold regression vs BFD ld: __ehdr_start
  - From: Cary Coutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]