This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 22/12/13 12:47, Alan Modra wrote: > On Fri, Dec 20, 2013 at 07:32:15PM +1100, Kugan wrote: >> [Apologies if you get this twice; Noticed a typo with email address] >> >> Hi, >> >> mongodb for aarch64 segfaults due to an error in applying GOT for TLS >> relocation. Michael Hudson-Doyle tracked this down to wrong usage of >> offset for the relocation. Attached patch (by Michael Hudson-Doyle) >> fixes this. Regression tested on aarch64-none-linux-gnu with no new >> regressions. >> >> Is this OK for trunk and backport for 2.24? > > Looks good to me. There are two more occurrences of > output_section->output_offset in elfnn-aarch64.c. Please fix those > too. > Thanks Alan for the review. Please fond the patch attached which changes it. make check for binutils, gas and ld has no new regression with the patch. Thanks, Kugan bfd/ +2013-12-28 Michael Hudson-Doyle <michael.hudson@linaro.org> + + * elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Use correct + offset while calculating relocation address. + * elfnn-aarch64.c (elfNN_aarch64_create_small_pltn_entry): Use correct + offset while calculating relocation address. +
Attachment:
p.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |